Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export bin/marked #2629

Merged
merged 1 commit into from Oct 30, 2022
Merged

feat: export bin/marked #2629

merged 1 commit into from Oct 30, 2022

Conversation

kapouer
Copy link
Contributor

@kapouer kapouer commented Oct 28, 2022

This allows tools like marked-man to extend marked and still use its cli.

This allows tools like marked-man to extend marked and still use its cli.
@vercel
Copy link

vercel bot commented Oct 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
marked-website ✅ Ready (Inspect) Visit Preview Oct 28, 2022 at 0:47AM (UTC)

@kapouer
Copy link
Contributor Author

kapouer commented Oct 28, 2022

For example:

#!/usr/bin/node

import { markedMan } from 'marked-man';
import { marked } from 'marked';

marked.use(markedMan);

import 'marked/bin/marked';

That makes it easy for an extension to be callable from command-line.

@UziTech UziTech linked an issue Oct 29, 2022 that may be closed by this pull request
Copy link
Member

@UziTech UziTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@UziTech UziTech changed the title export bin/marked feat: export bin/marked Oct 30, 2022
@UziTech UziTech merged commit bd8aad9 into markedjs:master Oct 30, 2022
@UziTech UziTech mentioned this pull request Oct 31, 2022
5 tasks
github-actions bot pushed a commit that referenced this pull request Oct 31, 2022
# [4.2.0](v4.1.1...v4.2.0) (2022-10-31)

### Features

* export bin/marked ([#2629](#2629)) ([bd8aad9](bd8aad9))
@kapouer
Copy link
Contributor Author

kapouer commented Nov 1, 2022

That's super cool, and marked 4 is so much easier to use.
marked-man becomes almost trivial to develop.

@UziTech
Copy link
Member

UziTech commented Nov 1, 2022

Awesome! Maybe we should use marked-man in marked to keep our man file up to date.

@kapouer
Copy link
Contributor Author

kapouer commented Nov 1, 2022

I've started updating marked-man to run with latest marked 4.2, so wait a little bit. I'll submit a PR when ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't use extensions from CLI
3 participants