Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails with marked-1.1.0 #28

Closed
sdgathman opened this issue Jun 5, 2020 · 16 comments
Closed

Fails with marked-1.1.0 #28

sdgathman opened this issue Jun 5, 2020 · 16 comments

Comments

@sdgathman
Copy link

Unmodified, immediately crashes with:

InlineLexer.prototype.html_output = InlineLexer.prototype.output;
            ^

TypeError: Cannot read property 'prototype' of undefined

Ok, so that internal name is Lexer now in marked. Will a simple rename work?

var InlineLexer = marked.Lexer;

Now the crash is:

$ npm test

> marked-man@0.7.0 test /home/stuart/fedora-scm/marked-man/marked-man-0.7.0
> node ./test/compare

(node:2476841) UnhandledPromiseRejectionWarning: TypeError: this.peek is not a function
Please report this to https://github.com/markedjs/marked.
    at Parser.parse (/home/stuart/fedora-scm/marked-man/marked-man-0.7.0/lib/marked-man.js:162:20)
    at Function.parse (/usr/lib/node_modules/marked/src/Parser.js:27:19)
    at Function.marked [as parse] (/usr/lib/node_modules/marked/src/marked.js:108:19)
    at convert (/home/stuart/fedora-scm/marked-man/marked-man-0.7.0/test/compare.js:12:20)
    at check (/home/stuart/fedora-scm/marked-man/marked-man-0.7.0/test/compare.js:87:2)
    at /home/stuart/fedora-scm/marked-man/marked-man-0.7.0/test/compare.js:41:4
    at new Promise (<anonymous>)
    at /home/stuart/fedora-scm/marked-man/marked-man-0.7.0/test/compare.js:40:10
    at Array.map (<anonymous>)
    at /home/stuart/fedora-scm/marked-man/marked-man-0.7.0/test/compare.js:39:20
(node:2476841) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 13)
(node:2476841) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
@kapouer
Copy link
Owner

kapouer commented Jun 5, 2020

Hello, thanks for that report. Will look into it. Ping me in a week or so if i forgot.

@sdgathman
Copy link
Author

ping

@kapouer
Copy link
Owner

kapouer commented Jun 23, 2020

Yep, sorry, fixing this is not that easy and i got busy. Will try again later, but keep pinging !

@dominikwilkowski
Copy link

I tried using Selective dependency resolutions but that failed as well:

"resolutions": {
	"marked-man/marked": "^0.7.0"
},

Can you please make marked a dependency until this is fixed?

svenstaro pushed a commit to archlinux/svntogit-community that referenced this issue Jul 22, 2020


git-svn-id: file:///srv/repos/svn-community/svn@664801 9fca08f4-af9d-4005-b8df-a31f2cc04f65
svenstaro pushed a commit to archlinux/svntogit-community that referenced this issue Jul 22, 2020


git-svn-id: file:///srv/repos/svn-community/svn@664801 9fca08f4-af9d-4005-b8df-a31f2cc04f65
@bedney
Copy link

bedney commented Aug 18, 2020

@kapouer - Thank you for this package.

Pinging you for a fix of this package so that we can upgrade to marked-1.1.0.

Thank you.

@alinex
Copy link

alinex commented Oct 10, 2020

marked is now at V1.2.0 but then will marked-man use the newer versions?

@sdgathman
Copy link
Author

Failure with marked-1.2.7:

(node:3326462) UnhandledPromiseRejectionWarning: TypeError: this.peek is not a function
Please report this to https://github.com/markedjs/marked.
    at Parser.parse (/home/stuart/fedora-scm/marked-man/marked-man-0.7.0/lib/marked-man.js:162:20)
    at Function.parse (/usr/lib/node_modules/marked/src/Parser.js:27:19)
    at Function.marked [as parse] (/usr/lib/node_modules/marked/src/marked.js:110:19)
    at convert (/home/stuart/fedora-scm/marked-man/marked-man-0.7.0/test/compare.js:12:20)
    at check (/home/stuart/fedora-scm/marked-man/marked-man-0.7.0/test/compare.js:87:2)
    at /home/stuart/fedora-scm/marked-man/marked-man-0.7.0/test/compare.js:41:4
    at new Promise (<anonymous>)
    at /home/stuart/fedora-scm/marked-man/marked-man-0.7.0/test/compare.js:40:10
    at Array.map (<anonymous>)
    at /home/stuart/fedora-scm/marked-man/marked-man-0.7.0/test/compare.js:39:20
(Use `node --trace-warnings ...` to show where the warning was created)
(node:3326462) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 13)
(node:3326462) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

@alinex
Copy link

alinex commented Jan 2, 2021

Ping again, will this be fixed any time?

@bedney
Copy link

bedney commented Jan 2, 2021

@kapouer -

Would making a donation through something like BountySource or Patreon help this along? I can throw a little cash in the pot (or buy you a bottle of your favorite wine or beer) if that would help :-).

Thank you for this project!

@hildjj
Copy link

hildjj commented Nov 16, 2021

ping.

@kapouer
Copy link
Owner

kapouer commented Nov 16, 2021

Luckily I am still alive. I've setup a reminder for tomorrow...

@bedney
Copy link

bedney commented Jun 8, 2022

@kapouer - Any thoughts on fixing this? As per my above message, I'm willing to contribute via Patreon, BountySource, beer etc.

@anthraxx
Copy link

anthraxx commented Oct 28, 2022

ping @kapouer we have marked 4.1.1 released in the meanwhile which is not compatible.

@kapouer
Copy link
Owner

kapouer commented Oct 28, 2022

On to it !

@kapouer
Copy link
Owner

kapouer commented Oct 28, 2022

Somewhat depending on markedjs/marked#2629 to avoid using another command line options parser.

@kapouer
Copy link
Owner

kapouer commented Nov 5, 2022

Fixed in version 1.0.0

@kapouer kapouer closed this as completed Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants