Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add Node.js 10 to CI and loosen engines field #2119

Merged
merged 5 commits into from Jun 22, 2021
Merged

fix: add Node.js 10 to CI and loosen engines field #2119

merged 5 commits into from Jun 22, 2021

Conversation

styfle
Copy link
Member

@styfle styfle commented Jun 21, 2021

Fixes #2111

@vercel
Copy link

vercel bot commented Jun 21, 2021 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/markedjs/markedjs/7ThYuLGW61Koh3MfZ2TjdFTKV9my
✅ Preview: https://markedjs-git-node-version-10-markedjs.vercel.app

@styfle styfle changed the title Add tests for node 10 Add Node.js 10 to CI and loosen engines field Jun 21, 2021
@styfle styfle marked this pull request as ready for review June 21, 2021 23:12
@styfle styfle changed the title Add Node.js 10 to CI and loosen engines field fix: add Node.js 10 to CI and loosen engines field Jun 21, 2021
@styfle styfle requested a review from UziTech June 21, 2021 23:12
@styfle styfle mentioned this pull request Jun 21, 2021
Closed
@UziTech
Copy link
Member

UziTech commented Jun 22, 2021 •
edited

This works but I don't think it solves the problem. V2.0.7 engines field was v8 so this is still dropping node versions without a major version change and it is supporting a node version after eol which is kind of worst of both worlds.

@styfle
Copy link
Member Author

styfle commented Jun 22, 2021

@UziTech I just tried Node 8 and it failed so I think we can still say this is a patch version to fix the engines field

@Fleker
Copy link

Fleker commented Jun 22, 2021

Thanks for doing this PR.

@calculuschild calculuschild reopened this Jun 22, 2021
@calculuschild
Copy link
Contributor

Gosh dang. I hate when the close PR button pops up under my thumb on mobile.

@UziTech UziTech merged commit 8659353 into master Jun 22, 2021
@UziTech UziTech deleted the node-version-10 branch June 22, 2021 17:25
github-actions bot pushed a commit that referenced this pull request Jun 22, 2021
@semantic-release-bot
chore(release): 2.1.2 [skip ci]
c7b4664 
## [2.1.2](v2.1.1...v2.1.2) (2021-06-22)

### Bug Fixes

* add Node.js 10 to CI and loosen `engines` field ([#2119](#2119)) ([8659353](8659353))
@github-actions
Copy link

🎉 This PR is included in version 2.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UziTech UziTech UziTech approved these changes

@calculuschild calculuschild calculuschild approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Breaking Change in 2.1.1
4 participants
@styfle @UziTech @Fleker @calculuschild