Skip to content

Commit

Permalink
fix: add Node.js 10 to CI and loosen engines field (#2119)
Browse files Browse the repository at this point in the history
  • Loading branch information
styfle committed Jun 22, 2021
1 parent 30c3d05 commit 8659353
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/tests.yml
Expand Up @@ -10,7 +10,8 @@ jobs:
if: "!contains(github.event.head_commit.message, '[skip ci]')"
strategy:
matrix:
node_version: [12, 'lts/*', 'node']
# lowest verison here should also be in `engines` field
node_version: [10, 12, 'lts/*', 'node']
runs-on: ubuntu-latest
steps:
- name: Checkout Code
Expand Down
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -83,6 +83,6 @@
"preversion": "npm run build && (git diff --quiet || git commit -am build)"
},
"engines": {
"node": ">= 12"
"node": ">= 10"
}
}

1 comment on commit 8659353

@vercel
Copy link

@vercel vercel bot commented on 8659353 Jun 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.