Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to spec 0.31.2 #1009

Merged
merged 2 commits into from Mar 2, 2024
Merged

Update to spec 0.31.2 #1009

merged 2 commits into from Mar 2, 2024

Conversation

notriddle
Copy link
Contributor

The spec update changes these things:

  • It simplifies the HTML regex so that <!-- a -- b --> is an HTML comment. HTML5 reports this as an error, but still parses it.
  • It changes the set of known HTML block elements to match HTML5, adding search and removing source.
  • It adds Unicode Symbols to the set of punctuation characters that are used to evaluate flankingness. This is blocked on Add Symbol category uc.micro#15

This commit also changes the declaration HTML regex to match lowercase, even though that change was technically made in spec version 0.30.

@rlidwka
Copy link
Member

rlidwka commented Mar 2, 2024

This is blocked on markdown-it/uc.micro#15

Blocker should be resolved.

Can you please rebase and update pull request?

@rlidwka
Copy link
Member

rlidwka commented Mar 2, 2024

Also, can you move actual code changes and spec update to separate commits, if that's too not much of a trouble? (i.e. one commit with test/fixtures/commonmark/* and another with everything else)

The spec update changes these things:

* It simplifies the HTML regex so that `<!-- a -- b -->` is an HTML
  comment. HTML5 reports this as an error, but still parses it.
* It changes the set of known HTML block elements to match HTML5, adding
  `search` and removing `source`.
* It adds Unicode Symbols to the set of punctuation characters that are
  used to evaluate flankingness.

This commit also changes the declaration HTML regex to match lowercase,
even though that change was technically made in spec version 0.30.
@notriddle
Copy link
Contributor Author

notriddle commented Mar 2, 2024

@rlidwka no problem! 👍

@puzrin puzrin merged commit d7ce5ec into markdown-it:master Mar 2, 2024
1 check passed
@notriddle notriddle deleted the spec-0.31.2 branch March 2, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants