fix quadratic complexity in reference parser #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanHotsiy
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
Thanks @rlidwka!!! Sorry for the delay.
This is amazing idea!
It improves the performance a lot! On my big list of reference links (1000 lines) it gets ~27x speed improvement 🔥
version from main
Sample: block-ref-list.md (63653 bytes)
> current x 16.89 ops/sec ±0.50% (45 runs sampled)
version from this branch
Sample: block-ref-list.md (63653 bytes)
> current x 437 ops/sec ±0.27% (91 runs sampled)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should fix #996
instead of calling
state.getLineson the entire thing (until empty line), it now pulls in lines as needed@RomanHotsiy please check if there's any improvement on your data