Added Atlassian Provider #341
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bentranter
requested changes
May 20, 2020
|
removed the binary, and rebased onto a single commit for cleanliness |
|
updated pr to resolve conflicts with okta addition, anyone want to take a second look? |
bentranter
reviewed
Jun 4, 2020
| @@ -9,6 +9,4 @@ require ( | |||
| github.com/lestrrat-go/jwx v0.9.0 | |||
| github.com/markbates/going v1.0.0 | |||
| github.com/mrjones/oauth v0.0.0-20180629183705-f4e24b6d100c | |||
| github.com/stretchr/testify v1.2.2 | |||
| golang.org/x/oauth2 v0.0.0-20180620175406-ef147856a6dd | |||
There was a problem hiding this comment.
These removals don't seem correct – we depend on testify for tests, and multiple providers depend on oauth2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not exactly sure what to say here, I've been using Goth and I wanted to use it with their 3LO for apps flow