Add login.gov provider #318
Conversation
andrewzah
force-pushed
the
login_gov-provider
branch
from
45d9c58
to
b2f29be
Compare
|
@techknowlogick I used this branch of goth (b2f29be) in a fork of gitea (diff: 4484323), and I ran into an issue. I was able to sign in successfully with login.gov to gitea and create a new account, but when someone else signed in with login.gov, they logged into my gitea account. Do you think this is an issue with my goth implementation? Or with my gitea one? |
|
@azah in terms of changes you made to gitea it looks like the code changes there are correct. Could you test with a different provider (github is easiest one to test with as we have many implementations of gitea using it, so we know that integration is solid) to see if same thing still happens? If same thing still happens with a different provider then it is likely due to a configuration of gitea, otherwise then it is likely due to something in this PR. |
|
@techknowlogick good idea. With github auth it worked correctly, so I'll take a look at this PR again on monday to see what might be causing the issue. |
* add example for new login.gov provider * sort example providers alphabetically
andrewzah
force-pushed
the
login_gov-provider
branch
from
b2f29be
to
453eecd
Compare
|
@techknowlogick as far as I'm aware, each call gets a new Could it be something to do with creating a new account in gitea? |
|
I've just created a login.gov account (I don't work for USG so I didn't realize it was open to any random person including non-americans), so I can help tetst. I haven't figured out how to make an oauth2 application so I can test with a local gitea install, do you have any insight into how to do that? |
|
@techknowlogick there's a process to getting approved. If you send an email to zah@andrewzah.com (or reply with your email/twitter) I can send you an issuer id/redirect_uri for testing goth and/or gitea. |
|
sent. ty :) |
|
@techknowlogick thanks, I sent you an email. I'm still using commit 4484323 from my gitea fork. You can replicate the issue by
|
This PR adds support for login.gov which uses a customized OIDC flow.
I adapted the oidc provider and tried to adhere to the style of the project; please let me know if you have any feedback.