Add functionality to revoke tokens #150
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
neumayer
commented
Mar 29, 2017
neumayer
commented
- Add revoke method to provider interface
- Implement method for github and gplus
- Add tests
- Add noop implementation to other providers
* Add revoke method to provider interface * Implement method for github and gplus * Add tests * Add noop implementation to other providers
|
Anyone interested? |
|
@neumayer my apologies for not looking at this sooner. I think this is fantastic, and definitely wanted. Please continue with the implementations, we need implementations for all the providers that support it before it can be merged. Thanks. |
|
Hehe, that includes me getting accounts with up to 32 identity providers, so it might take a couple of days :-) But I'll try to keep working on it when I find the time. |
|
I looked at both twitch and amazon today. While I hunted down some secret amazon api endpoint, there's no documentation for it and I didn't manage to authenticate to it. Since it's not documented at all I think it's not worth pursuing that. I added a short comment about this. |
…unction getProviderName
… provder is not string
…unction getProviderName
… provder is not string
…session Provider name from session
* Add revoke method to provider interface * Implement method for github and gplus * Add tests * Add noop implementation to other providers
It's new in master.
This is needed because of changes to handling multiple logins introduced in 9885e53.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.