Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Chunk.modules DeprecationWarning in Webpack 3.x #3

Merged
merged 1 commit into from Aug 22, 2017

Conversation

steven-prybylynskyi
Copy link
Contributor

Updates to Chunk.mapModules is not backwards compatible with Webpack 2.x due to breaking changes in webpack/webpack#4764

Following should be added to README:

Install

# for webpack 3
npm install --save-dev extract-text-webpack-plugin
# for webpack 1, 2
npm install --save-dev extract-text-webpack-plugin@0.1.0

@steven-prybylynskyi
Copy link
Contributor Author

devDependencies needs to be updated too for CI

Updates to Chunk.mapModules is not backwards compatible with Webpack 2.x due to breaking changes in webpack/webpack#4764
@ghost
Copy link

ghost commented Aug 15, 2017

Please merge...

@steven-prybylynskyi
Copy link
Contributor Author

@ddeboer-axtion only the owner of the repo @mariusbalcytis can do that

@ghost
Copy link

ghost commented Aug 21, 2017

Yeah i know, I was hoping he would read the message ;)

@mariusbalcytis mariusbalcytis merged commit b6973a1 into mariusbalcytis:master Aug 22, 2017
@mariusbalcytis
Copy link
Owner

Thanks for the pull request and sorry for the delay.

@steven-prybylynskyi
Copy link
Contributor Author

ah, even don't mention it )

@arianrhodsandlot
Copy link

Bad news: forEachModule is also deprecated as described here: webpack/webpack#6367 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants