[DST-379]: Docs: Persist Theme

[OsamaAbdellateef]

No description provided.

[changeset-bot]

🦋 Changeset detected

Latest commit: 9b83a44

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages

Name	Type
@marigold/docs	Patch
@marigold/system	Patch
@marigold/components	Patch
@marigold/icons	Patch
@marigold/theme-preset	Patch
@marigold/theme-b2b	Patch
@marigold/theme-core	Patch
@marigold/storybook-config	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
marigold-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 10, 2024 3:09pm
marigold-storybook	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 10, 2024 3:09pm

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
marigold-production	⬜️ Ignored (Inspect)	Visit Preview		May 10, 2024 3:09pm

[sebald]

LGTM just one question: with this implementation, people can not deeplink (with a certain theme). Should we add this or leave it?

@sarahgm @OsamaAbdellateef @aromko @KadaStrophe

[OsamaAbdellateef]

LGTM just one question: with this implementation, people can not deeplink (with a certain theme). Should we add this or leave it?

@sarahgm @OsamaAbdellateef @aromko @KadaStrophe

you mean when you have a deep link and then switch the theme u lose the deep link ? @sebald

[sebald]

LGTM just one question: with this implementation, people can not deeplink (with a certain theme). Should we add this or leave it?
@sarahgm @OsamaAbdellateef @aromko @KadaStrophe

you mean when you have a deep link and then switch the theme u lose the deep link ? @sebald

Yes :) like always having the ?theme=core query appended

[OsamaAbdellateef]

LGTM just one question: with this implementation, people can not deeplink (with a certain theme). Should we add this or leave it?
@sarahgm @OsamaAbdellateef @aromko @KadaStrophe

you mean when you have a deep link and then switch the theme u lose the deep link ? @sebald

Yes :) like always having the ?theme=core query appended

For me i would say it is good to have

[OsamaAbdellateef]

LGTM just one question: with this implementation, people can not deeplink (with a certain theme). Should we add this or leave it?
@sarahgm @OsamaAbdellateef @aromko @KadaStrophe

you mean when you have a deep link and then switch the theme u lose the deep link ? @sebald

Yes :) like always having the ?theme=core query appended

done ✔️ @sebald

[OsamaAbdellateef]

Should be working now @sebald