Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump requests_toolbelt to resolve deprecation warning in urllib3 #384

Closed

Conversation

fredlb
Copy link
Contributor

@fredlb fredlb commented Nov 11, 2022

Bumping this to fix deprecation warning regarding urllib3.contrib.pyopenssl.
In a project I am seeing this:

../../../../.local/share/virtualenvs/services-qVuiE_5A/lib/python3.9/site-packages/keycloak/__init__.py:43: in <module>
    from .keycloak_admin import KeycloakAdmin
../../../../.local/share/virtualenvs/services-qVuiE_5A/lib/python3.9/site-packages/keycloak/keycloak_admin.py:34: in <module>
    from requests_toolbelt import MultipartEncoder
../../../../.local/share/virtualenvs/services-qVuiE_5A/lib/python3.9/site-packages/requests_toolbelt/__init__.py:12: in <module>
    from .adapters import SSLAdapter, SourceAddressAdapter
../../../../.local/share/virtualenvs/services-qVuiE_5A/lib/python3.9/site-packages/requests_toolbelt/adapters/__init__.py:12: in <module>
    from .ssl import SSLAdapter
../../../../.local/share/virtualenvs/services-qVuiE_5A/lib/python3.9/site-packages/requests_toolbelt/adapters/ssl.py:16: in <module>
    from .._compat import poolmanager
../../../../.local/share/virtualenvs/services-qVuiE_5A/lib/python3.9/site-packages/requests_toolbelt/_compat.py:56: in <module>
    from requests.packages.urllib3.contrib.pyopenssl \
../../../../.local/share/virtualenvs/services-qVuiE_5A/lib/python3.9/site-packages/urllib3/contrib/pyopenssl.py:82: in <module>
    warnings.warn(
E   DeprecationWarning: 'urllib3.contrib.pyopenssl' module is deprecated and will be removed in a future release of urllib3 2.x. Read more in this issue: https://github.com/urllib3/urllib3/issues/2680

Which seems to have been fixed in this PR for requests_toolbelt requests/toolbelt#336.

Bumping this to 0.10.1 resolved my issue above. Not sure why this is happening as I have another project using python-keycloak 2.6.0 just fine. Might be some clashing of urllib3 versions between deps, or something?

Bumping this to fix deprecation warning regarding urllib3.contrib.pyopenssl
@fredlb
Copy link
Contributor Author

fredlb commented Nov 11, 2022

I can see that the tests are failing, but it did work for me locally (python 3.10). I can also see that the daily check is failing so not sure if its connected to that.

@fredlb
Copy link
Contributor Author

fredlb commented Nov 11, 2022

Right, so seems like the latest tag is now referring to v20 of Keycloak, and it does indeed cause some tests to fail.

@ryshoooo
Copy link
Collaborator

Hi @fredlb

The tests should be running fine now :) I've made a general update to most dependencies, but this PR could be still relevant. Can you check if the warning still appears in v2.6.1?

@ryshoooo
Copy link
Collaborator

ryshoooo commented Mar 5, 2023

Closing as requests-toolbet are already updated on master :)

@ryshoooo ryshoooo closed this Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants