-
Notifications
You must be signed in to change notification settings - Fork 29
[#74] feat: add imported css to its importer #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all, thank you for your contribution! 👍
We need to make this behavior configurable since currently the library is used with the existing behavior.
What we can do is:
- Make this behavior configurable (I know you think this is a bug, but we need to think of this as an improvement)
Someone could have the need to inject the CSS once and for all since this can impact performance in certain cases. The configuration flag can be named as 'relativeCSSInjection' a boolean when true the behavior you proposed will be enabled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect!
Give me the time to test locally and write documentation and I will notify you of the new release!
@mseyfayi Does this feature work with clean usage (without vue or anything) or am I doing something wrong? If you have time can you give me an example? A test repository because with my tests I can't get the desired result, maybe I'm doing something wrong. Thanks in advance! |
I apologize for not getting back to you sooner. But still, I'm not sure! |
No description provided.