Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support providing a list of allowed packages #21

Merged
merged 3 commits into from Jun 21, 2022
Merged

feat: support providing a list of allowed packages #21

merged 3 commits into from Jun 21, 2022

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Jun 20, 2022

I've tried to write a test, but couldn't get it to work - it doesn't seem to accept the flag value I try to set (I also tried passing in a whole custom flag instance).

@maratori let me know what you'd like to do.

Resolves #20

Copy link
Owner

@maratori maratori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@G-Rath Thanks for contribution!
Small comments from my side.

pkg/testpackage/testpackage.go Outdated Show resolved Hide resolved
pkg/testpackage/testpackage.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #21 (0e3477c) into master (16bac89) will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #21   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          27     36    +9     
=====================================
+ Hits           27     36    +9     
Impacted Files Coverage Δ
pkg/testpackage/testpackage.go 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16bac89...0e3477c. Read the comment docs.

pkg/testpackage/testpackage.go Outdated Show resolved Hide resolved
pkg/testpackage/testpackage.go Outdated Show resolved Hide resolved
@G-Rath G-Rath requested a review from maratori June 21, 2022 03:56
Copy link
Owner

@maratori maratori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@G-Rath Thanks for contribution
I'll prepare new release this week (so dependabot will update it in golangci-lint).

@maratori maratori merged commit 37f5d17 into maratori:master Jun 21, 2022
@G-Rath G-Rath deleted the support-main branch June 21, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow package main
2 participants