Merge pull request #13 from sawa-zen/fix/tabindex

fix: patch tabindex rule
maranran · May 20, 2019 · 70c91ac · 70c91ac
2 parents 0c182d9 + cac30a4
commit 70c91ac
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/lib/rules/tabindex-no-positive.js b/lib/rules/tabindex-no-positive.js
@@ -23,14 +23,9 @@ module.exports = {
   create (context) {
     return VueUtils.defineTemplateBodyVisitor(context, {
       "VAttribute" (node) {
-        let tabindex;
-        if (node.directive) {
-          tabindex = node.key.argument.name === 'tabindex';
-        } else {
-          tabindex = node.key.name === 'tabindex';
-        }
-
-        if (!tabindex) {
+        const isTabindex = (!node.directive && node.key.name === 'tabindex')
+          || (node.key.name.name === 'bind' && node.key.argument.name === 'tabindex')
+        if (!isTabindex) {
           return;
         }
 

diff --git a/tests/lib/rules/tabindex-no-positive.js b/tests/lib/rules/tabindex-no-positive.js
@@ -23,6 +23,10 @@ tester.run('tabindex-no-positive', rule, {
       filename: 'test.vue',
       code: '<template><span tabindex="0"></span></template>',
     },
+    {
+      filename: 'test.vue',
+      code: '<template><span v-if="true" tabindex="0"></span></template>',
+    },
     {
       filename: 'test.vue',
       code: '<template><span tabindex="-1"></span></template>',