Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: android example crashing on launch #372

Merged
merged 2 commits into from
May 28, 2024
Merged

fix: android example crashing on launch #372

merged 2 commits into from
May 28, 2024

Conversation

tyrauber
Copy link
Sponsor Collaborator

@tyrauber tyrauber commented May 9, 2024

Description

ReactNativeFlipper.initializeFlipper is no longer required in ReactNative >70. Calling initializeFlipper crashes the app on Launch.

Checklist

  • I have tested this on a device/simulator for each compatible OS
  • I formatted JS and TS files with running yarn lint:fix in the root folder
  • I have run tests via yarn test in the root folder
  • I updated the documentation with running yarn generate in the root folder
  • I mentioned this change in CHANGELOG.md
  • I updated the typings files (index.d.ts)
  • I added/updated a sample (/example)

@tyrauber
fix: android example crashing on launch
8b347a4 
ReactNativeFlipper.initializeFlipper is no longer required
@tyrauber
chore: update changelog
cb6d321
@tyrauber tyrauber merged commit aeef5c3 into maplibre:main May 28, 2024
1 check failed
@tyrauber tyrauber deleted the fix/android_example_crash branch May 28, 2024 08:50
@tyrauber tyrauber mentioned this pull request May 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@tyrauber