Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on gazetteer #1898

Merged
merged 1 commit into from
Dec 11, 2022
Merged

Remove dependency on gazetteer #1898

merged 1 commit into from
Dec 11, 2022

Conversation

rotu
Copy link
Contributor

@rotu rotu commented Dec 1, 2022

Removes dependency on gazetteer, which was only being used for a single GeoJSON file for benchmarks but pulled in a number of deprecated packages.

Fix #1897

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Manually test the debug page.
  • Add an entry to CHANGELOG.md under the ## main section.

@rotu rotu marked this pull request as ready for review December 1, 2022 22:14
@HarelM
Copy link
Member

HarelM commented Dec 1, 2022

Thanks for taking the time to open this PR!
I'm not sure removing a benchmark is the right approach. These benchmarks help up make sure we don't introduce performance issues.
I would consider adding the file from the other repo here instead.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

Bundle size report:

Size Change: 0 B
Total Size Before: 206 kB
Total Size After: 206 kB

Output file Before After Change
maplibre-gl.js 197 kB 197 kB 0 B
maplibre-gl.css 9.1 kB 9.1 kB 0 B
ℹ️ View Details No major changes

@rotu
Copy link
Contributor Author

rotu commented Dec 2, 2022

@HarelM Good points. I'm skeptical that this file has enough going on in it to provide meaningful performance metrics. Is there a meatier GeoJSON file to use instead?

@HarelM
Copy link
Member

HarelM commented Dec 2, 2022

@wipfli @xabbu42 do you guys have input on this?

@xabbu42
Copy link
Contributor

xabbu42 commented Dec 2, 2022

The removed benchmark is actually very valuable and has itself nothing todo with geojson. The geojson is only used as a list of locations to benchmark. I agree that we should just include a copy of the file in this repository, which also would allow us the add/remove locations from the benchmark if we want to.

@rotu
Copy link
Contributor Author

rotu commented Dec 5, 2022

@xabbu42 I totally misunderstood you - thanks for your patience! Yes, it does seem this benchmark does something, though I still can't say I truly grasp how the benchmarks work!

@xabbu42
Copy link
Contributor

xabbu42 commented Dec 5, 2022

@rotu no worries, thanks for taking the time to improve maplibre!

@HarelM HarelM merged commit b1a5851 into maplibre:main Dec 11, 2022
@rotu rotu deleted the remove-gazetteer branch December 19, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary dependency on gazetteer
4 participants