stream add-source file upload #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gerdie
force-pushed
the
upload_connection
branch
from
c27384d
to
b828fd8
Compare
Gerdie
force-pushed
the
upload_connection
branch
from
b828fd8
to
7a1dbd4
Compare
dnomadb
reviewed
Feb 6, 2020
tilesets/scripts/cli.py
Outdated
| @@ -303,35 +302,41 @@ def validate_source(features): | |||
| @cli.command("add-source") | |||
| @click.argument("username", required=True, type=str) | |||
| @click.argument("id", required=True, type=str) | |||
| @cligj.features_in_arg | |||
| @click.argument("filename", required=True, type=str) | |||
There was a problem hiding this comment.
@Gerdie using @cligj means that we both:
- Can handle ld and non ld geojson (iow abstract this for the user)
- Validate and parse the geojson before passing in
I think we'll have to find a way to stream from input vs from a file. I think we have a few options:
- Stream in to temp file, stream temp file to upload
cligjevaluates lazily so directly streaming in chunks (probably would be the weirdest to implement but most efficient overall)- ?
dnomadb
suggested changes
Feb 6, 2020
dnomadb
suggested changes
Feb 14, 2020
Gerdie
force-pushed
the
upload_connection
branch
from
ee30e21
to
487abe5
Compare
dnomadb
approved these changes
Feb 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
streaming to avoid issues related to running out of memory: #31