-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for node Node 21, update AppVeyor and tests #712
base: master
Are you sure you want to change the base?
Conversation
- Updated abi_crosswalk.json to include node 18 (current). - Added test coverage for cases of unsupported/unknown targets.
This reverts commit 7804f5c.
Does anyone ( @cclauss ) have any ideas for the node 20 appveyor errors? node 18 seems to run fine but node 20 gets some tests failures that look like possible line endings (\n) issues |
fix github warning error
Co-authored-by: Christian Clauss <cclauss@me.com>
Failing tests are an extra node-pre-gyp/test/build.test.js Line 140 in a74f5e3
Line 11 in a74f5e3
|
an extra "\n" where though |
matrix: # https://github.com/nodejs/release#release-schedule | ||
- nodejs_version: 16 | ||
- nodejs_version: 18 | ||
- nodejs_version: 20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made this change, but i'm not sure it is corrent since it seemed only lts releases were listed here before
Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
This is a merge of #649 #711 and #709 as requested by #649 (comment)
This PR updates node-pre-gyp to support up to Node 21.
1.) I updated abi_crosswalk.json to include node 21 with 'npm run update-crosswalk'
2.) It adds test coverage for cases of unsupported/unknown targets from #649
3.) It adds building with msvs 2022 and get AppVeyor to pass, from #709
Known Issues
Some tests are failing in node 20 and 21 for what look like minor line ending issues or slight path differences (which seem like differences in the responses from the node versions used more than a real issue with node-pre-gyp)
Testing
I have been using an updated abi_crosswalk.json in @acalcutt/node-pre-gyp and have used it with maplibre-native package up to node 20 (not to 21 only because we are only supporting lts releases)
Note from my own fork testing
Do not publish this from windows, it messes up the line endings in abi_crosswalk.json and makes the package fail on linux.