Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add node 15 support #518

Closed
wants to merge 1 commit into from
Closed

Conversation

ewanharris
Copy link
Contributor

I ran the scripts/abi_crosswalk.js script to update the abi_crosswalk file

Closes #517

@piranna
Copy link

piranna commented Oct 24, 2020

There are some errors on CI, can you review them? I'm having problems with node-pre-gyp in Node.js 15...

@ewanharris
Copy link
Contributor Author

ewanharris commented Oct 24, 2020

@piranna The failures on this PR look to be identical to the current state of the master branch. I tested this change with a native module my company uses and the module built fine for me, what issues are you having?

Edit:

The failing tests look to be due to a change in node-gyp between npm@5 (node-gyp@3.6.2)and npm@6 (node-gyp@5.1.0), it appears that passing the invalid python flag down no longer works

Edit 2:

I think it's down to improved python detection in node-gyp introduced by nodejs/node-gyp/pull/1582, filed #519 to adapt to those changes

@piranna
Copy link

piranna commented Oct 24, 2020

what issues are you having?

With node-canvas, after upgrading to Node.js 15 (and by extension, npm 7), it told me that Node.js API versions are incompatible. Rebuild didn't help, so I fully deleted both node_modules and build directories, and when running npm install it fails since it says there's no node-pre-gyp executable, and in fact the node_modules/.bin folder doesn't exists...

@ewanharris
Copy link
Contributor Author

@piranna, you could try either patching node_modules/node-pre-gyp/lib/util/abi_crosswalk.json with the changes you see in this PR to get it building or downgrade Node.js to 14.x until this PR is merged

@piranna
Copy link

piranna commented Oct 24, 2020

@piranna, you could try either patching node_modules/node-pre-gyp/lib/util/abi_crosswalk.json with the changes you see in this PR to get it building or downgrade Node.js to 14.x until this PR is merged

I'm not in a hurry, I can wait :-)

@ewanharris
Copy link
Contributor Author

Closing as this was done by #520

@ewanharris ewanharris closed this Oct 28, 2020
@ewanharris ewanharris deleted the node15 branch October 28, 2020 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to 15.0.0
2 participants