Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAVAND-979: use distance-dependent default rounding increments #6789

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dzinad
Copy link
Contributor

@dzinad dzinad commented Jan 5, 2023

Open after #6786 merge.

@dzinad dzinad force-pushed the NAVAND-979-dd-rounding-increment branch 2 times, most recently from 288ca0c to 3d005cb Compare January 5, 2023 16:23
@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Merging #6789 (bad7ba3) into main (662c318) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #6789      +/-   ##
============================================
+ Coverage     73.79%   73.82%   +0.02%     
- Complexity     5991     5996       +5     
============================================
  Files           818      818              
  Lines         31976    32010      +34     
  Branches       3811     3815       +4     
============================================
+ Hits          23596    23630      +34     
  Misses         6870     6870              
  Partials       1510     1510              
Impacted Files Coverage Δ
...igation/base/formatter/DistanceFormatterOptions.kt 97.50% <100.00%> (ø)
...ox/navigation/core/formatter/MapboxDistanceUtil.kt 96.23% <100.00%> (+0.84%) ⬆️

@dzinad dzinad force-pushed the NAVAND-979-dd-rounding-increment branch from 3d005cb to f9b8a72 Compare January 6, 2023 12:33
@dzinad dzinad force-pushed the NAVAND-979-dd-rounding-increment branch from f9b8a72 to e50af0f Compare May 31, 2023 10:31
@github-actions
Copy link

Changelog

Features

  • Added RouteProgress#inParkingAisle field indicating whether the current location belongs to a parking aisle. [#7212](https://github.com/mapbox/mapbox-navigation-android/pull/7212)

Bug fixes and improvements

  • Made default rounding increment in DistanceFormatterOptions dependent on distance numerical value. [#dd2](https://github.com/mapbox/mapbox-navigation-android/pull/dd2)
  • Supported displaying distances in yards for imperial UnitType in the UK locale. [#6786](https://github.com/mapbox/mapbox-navigation-android/pull/6786)

Known issues ⚠️

Other changes

Android Auto Changelog

Features

Bug fixes and improvements

@dzinad dzinad changed the title Navand 979 dd rounding increment NAVAND-979: use distance-dependent default rounding increments May 31, 2023
@dzinad dzinad marked this pull request as ready for review May 31, 2023 10:32
@dzinad dzinad requested a review from a team as a code owner May 31, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant