DirectionsRoute to NavigationRoute refactoring #6516
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Squashed commits: [f265764b67] Revert "- Added Waypoints to NavigationRoute; - RouteOptionsUpdater refactored." This reverts commit b111ebe6f3b3396fa14212e88f2316ccc76f3cac. [250633f2c7] NavigationRoute: create from DirectionsRoute(s) [b111ebe6f3] - Added Waypoints to NavigationRoute; - RouteOptionsUpdater refactored.
|
I think it's unblocked now. |
dzinad
reviewed
Jan 6, 2023
| @@ -203,6 +205,44 @@ class NavigationRoute internal constructor( | |||
| } | |||
| } | |||
|
|
|||
| internal fun create( | |||
There was a problem hiding this comment.
Is this used only for tests? Now it looks like it. Why can't you do all these json manipulations directly in the test-only method? For example, in NavigationRouteEx.
I don't like adding this method to production code because it duplicates directions response structure. And now the knowledge of this structure only lives in mapbox-java, which I think is good and it should stay this way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
blocked by #6005