Sb vanishing tree experiment #6493
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cafesilencio
force-pushed
the
sb-vanishing-tree-experiment
branch
from
af1934d
to
fa78685
Compare
cafesilencio
force-pushed
the
sb-vanishing-tree-experiment
branch
from
fa78685
to
c06dcb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactoring of the vanishing route line implementation to remove the need to consume route progress updates. Many of the previous calculations have been removed reducing the complexity and moving parts of the feature.
The elimination of the need to consume route progress updates makes the feature easier to use by developers since they only have to listen to
OnIndicatorPositionChangedListenerevents and forward them to the route line API.Screenshots or Gifs