no-op if geolocation query returns after control has been removed #12332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mourner
approved these changes
Oct 25, 2022
stepankuzmin
approved these changes
Oct 25, 2022
MinhOmega
added a commit
to MinhOmega/mapbox-gl
that referenced
this pull request
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launch Checklist
As described in the linked issue, there's a race condition in which a map can be set up, a geolocate control added, and then removed before the geolocate control's query for geolocation support finishes, which will throw an error. This PR fixes that race condition by making
_setupUIa no-op if the a map is no longer attached to the control.mapbox-gl-jschangelog:<changelog>Fix an issue where Geolocate control would throw an error if it's removed before determining geolocation support</changelog>