Add placementTime metric #11043
Merged
Add placementTime metric #11043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansis
approved these changes
Sep 30, 2021
src/util/performance.js
Outdated
| frame(timestamp: number, isRenderFrame: boolean) { | ||
| // Ignore frametimes during loading |
There was a problem hiding this comment.
Can we skip this for now and add while reviewing the rendering benchmarks more closely?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding this metric to better quantify the impact of #10795 .
Since
PausablePlacementis has a time budget per frame, any regressions in performance there might not surface upto observable framerate directly.This measures the average time required for placement to fully finish, including the time it stays paused between frames.Based on some suggestions from @ansis , I changed this to instead measure total time spent during placement.
In the same convo we also discussed how both this and frameTimes would be better if we only measured them after the
full-loadhas happened and during an animation.This PR also adds the changes for that.We decided to skip the frameTime measurement changes for now and focus on just the changes for the placementTime metric.