Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates GL JS examples to ES6 in /mapbox-gl-js #10818

Closed
wants to merge 1 commit into from
Closed

Conversation

domlet
Copy link
Contributor

@domlet domlet commented Jul 3, 2021

Related to https://github.com/mapbox/documentation/issues/698 and https://github.com/mapbox/mapbox-gl-js-docs/issues/263

Description

  • Updates tests to assert that all examples use ES6.
  • Updates all inline examples to use ES6.

To-do

Task Owner Status
Enable jsdoc/check-examples to identify examples that need to be updated and to assert examples moving forward: #9616. (Note: The jsdoc eslint plugin doesn't have --fix flag yet (ref gajus/eslint-plugin-jsdoc#336).)
Update all examples to ES6 SIGN_UP_HERE

Launch Checklist

  • Run npm test
  • Review by person in "Reviewer" column
  • briefly describe the changes in this PR
  • include before/after visuals or gifs if this PR includes visual changes
  • write tests for all new functionality
  • document any changes to public APIs
  • post benchmark scores
  • manually test the debug page
  • tagged @mapbox/gl-native if this PR includes shader changes or needs a native port
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
  • add an entry inside this element for inclusion in the mapbox-gl-js changelog: <changelog></changelog>

@domlet domlet marked this pull request as draft July 6, 2021 19:44
@domlet
Copy link
Contributor Author

domlet commented Jul 17, 2021

Closing in favor of #10707 which includes ES6 updates to inline examples.

@domlet domlet closed this Jul 17, 2021
@domlet domlet deleted the sprint/es6 branch July 17, 2021 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant