[@mantine/core] NumberInput: Fix ignored allowNegative prop (#6162) #6170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
davydkov
added a commit
to likec4/likec4
that referenced
this pull request
May 18, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@mantine/core](https://mantine.dev/) ([source](https://togithub.com/mantinedev/mantine/tree/HEAD/packages/@mantine/core)) | [`^7.9.0` -> `^7.9.1`](https://renovatebot.com/diffs/npm/@mantine%2fcore/7.9.0/7.9.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@mantine/hooks](https://mantine.dev) ([source](https://togithub.com/mantinedev/mantine/tree/HEAD/packages/@mantine/hooks)) | [`^7.9.0` -> `^7.9.1`](https://renovatebot.com/diffs/npm/@mantine%2fhooks/7.9.0/7.9.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>mantinedev/mantine (@​mantine/core)</summary> ### [`v7.9.1`](https://togithub.com/mantinedev/mantine/releases/tag/7.9.1) [Compare Source](https://togithub.com/mantinedev/mantine/compare/7.9.0...7.9.1) ##### What's Changed - `[@mantine/core]` Fix `theme.scale` being ignored in Input, Paper and Table border styles - `[@mantine/core]` Fix `virtualColor` function requring `use client` in Next.js - `[@mantine/core]` FloatingIndicator: Fix incorrect resize observer logic ([#​6129](https://togithub.com/mantinedev/mantine/issues/6129)) - `[@mantine/core]` NumberInput: Fix incorrect `allowNegative` handling with up/down arrows ([#​6170](https://togithub.com/mantinedev/mantine/issues/6170)) - `[@mantine/core]` Fix `error={true}` prop set on Checkbox, Radio and Switch rendering unxpected error element with margin - `[@mantine/core]` SegmentedControl: Fix `theme.primaryColor` not being respected in the focus ring styles - `[@mantine/core]` CloseButton: Fix incorrect specificity of some selectors - `[@mantine/core]` Fix incorrect `aria-label` handling in Select, Autocomplete, MultiSelect and TagsInputs components ([#​6123](https://togithub.com/mantinedev/mantine/issues/6123)) - `[@mantine/core]` Modal: Prevent `onClose` from being called when modal is not opened ([#​6156](https://togithub.com/mantinedev/mantine/issues/6156)) - `[@mantine/core]` PasswordInput: Fix duplicated password visibility icon in Edge browser ([#​6126](https://togithub.com/mantinedev/mantine/issues/6126)) - `[@mantine/hooks]` use-hash: Fix hash value not being updated correctly ([#​6145](https://togithub.com/mantinedev/mantine/issues/6145)) - `[@mantine/emotion]` Fix incorrect transform logic that was causing extra hooks to render ([#​6159](https://togithub.com/mantinedev/mantine/issues/6159)) ##### New Contributors - [@​lachtanek](https://togithub.com/lachtanek) made their first contribution in [mantinedev/mantine#6145 - [@​hsskey](https://togithub.com/hsskey) made their first contribution in [mantinedev/mantine#6156 - [@​ataldev](https://togithub.com/ataldev) made their first contribution in [mantinedev/mantine#6198 - [@​OliverWales](https://togithub.com/OliverWales) made their first contribution in [mantinedev/mantine#6188 - [@​AustinWildgrube](https://togithub.com/AustinWildgrube) made their first contribution in [mantinedev/mantine#6170 - [@​theca11](https://togithub.com/theca11) made their first contribution in [mantinedev/mantine#6178 **Full Changelog**: mantinedev/mantine@7.9.0...7.9.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/likec4/likec4). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjMuNSIsInVwZGF0ZWRJblZlciI6IjM3LjM2My41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Denis Davydkov <denis@davydkov.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After looking into #6162, I found that commit 081a47a removed the
allowNegativeprop. This PR brings back support for it and fixes the bug where theNumberInputcould go negative.