Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@mantine/core] feat: adding some default variants to notification #6134

Conversation

sindrefl
Copy link

Hello,

First time contributor, but long time user of the mantine library.

I wanted to get some familiarity with the mantine codebase, and add something of value at the same time, so I took a look at adding some of the standard variants in the color-variants-resolver to the Notification component.

I looked at Alert for inspiration, and have tried not to introduce any breaking changes. Updated storybook and documentation highlighting the three variants:

Outline - same as Notification base component
Filled - proposal for filled version with autocontrast support
Light - proposal for light version similar to Alert

Let me know what you think and if any changes are required

@sindrefl sindrefl force-pushed the feat/adding-variants-to-notification-component branch from 8982ece to 173b9dd Compare April 26, 2024 11:17
@rtivital
Copy link
Member

rtivital commented May 2, 2024

Thanks for showing interest in contributing to Mantine! Variants are not planned to be introduced to the Notification component. If you need to change component styles, you can do that with Styles API.

@rtivital rtivital closed this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants