Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slow rerendering of large tables #5684

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Smert
Copy link

@Smert Smert commented Jan 30, 2024

Hi! I have lags with rerendering of large tables with memoized rows:

const TestRow = memo(function Row() {
  return (
    <Table.Tr>
      {new Array(10).fill(0).map((_, index) => (
        <Table.Td key={index}>Cell</Table.Td>
      ))}
    </Table.Tr>
  );
});

function TestTable() {
  const [counter, setCounter] = useState(0);
  return (
    <>
      <p>Counter: {counter}</p>
      <button onClick={() => setCounter(counter + 1)}>Increment</button>
      <Table>
        <Table.Tbody>
          {new Array(1000).fill(0).map((_, index) => (
            <TestRow key={index}/>
          ))}
        </Table.Tbody>
      </Table>
    </>
  );
}

Eventloop lags for 200ms when I click on the button in this simple example. But all rows are memoized.
I noticed then TableContext have a new value every render. It leads to rerender of Table.Tr and Table.Td:

Screenshot 2024-01-30 at 19 52 06

Memoizing of the context and useStyle can improve performance:
Screenshot 2024-01-30 at 19 48 48

I can suggest my decision of this problem in the pull request. Maybe you have another ideas.

const themeName = (Array.isArray(name) ? name : [name]).filter((n) => n) as string[];
const themeName = useMemo(
() => (Array.isArray(name) ? name : [name]).filter((n) => n) as string[],
[String(name)]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting String(name) in the dependency array may not work as intended.
How about putting the value of name directly in the dependency array?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants