Don't modify head tag in next app router example #5199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtivital
force-pushed
the
master
branch
11 times, most recently
from
9ea2fcd
to
eebd557
Compare
The [Next docs for app router] say that the `<head>` tag shouldn't be modified manually. One repercussion of ignoring this advice is that Cypress e2e tests don't work anymore when testing app router based Next app where the `<head>` tag was modified manually. So I think the Mantine docs shouldn't propose doing this. As far as I can tell, the `<ColorSchemeScript />` works fine when put in the `<body>`.
moritzreiter
force-pushed
the
patch-1
branch
from
d29ceff
to
2f2f291
Compare
rtivital
added
the
Reviewed PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Next docs for app router say that the
<head>tag shouldn't be modified manually.One repercussion of ignoring this advice is that Cypress e2e tests don't work anymore when testing an app router based Next app where the
<head>tag was modified manually.So I think the Mantine docs shouldn't propose doing this.
As far as I can tell, the
<ColorSchemeScript />works fine when put in the<body>.