PEP440 versions #1653
Merged
PEP440 versions #1653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test with the style of versions that was dropped in packaging 22
This conforms to PEP440 and avoids issues with packaging 22
For cases with older version numbers we still need to handle underscores update tests
samtygier-stfc
force-pushed
the
1652-post-version
branch
from
717bfe9
to
c84b1b0
Compare
DolicaAkelloEgwel
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #1652
Description
Use
.postinstead of_for commit count since tagAlso add a test case that would have caught the problem.
Testing
Once merged check that IDAaaS unstable build launches
Acceptance Criteria
Documentation