Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade: bump orbyter-ml-dev with line-profiler and isort #79

Merged
merged 1 commit into from Apr 13, 2021

Conversation

rameshvs
Copy link
Contributor

@rameshvs rameshvs commented Apr 9, 2021

Upgrades orbyter-ml-dev:

  • isort 5.8.0 (so we can use the new --overwrite-in-place option; see isort issue)
  • add line profiler by default since it's a useful tool

Closes #71.

@rameshvs rameshvs force-pushed the rameshvs/orbyter-ml-dev-3.4 branch from 56192e7 to 348e522 Compare April 9, 2021 20:53
Copy link
Contributor

@mstefferson mstefferson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDK what's up with the xgboost changes but LGTM

For a complete list all packages, run `pip freeze` in a container. Below is a summary of
the useful packages for ML development.
For a complete list all packages, run `pip freeze` in a container. For a summary of
the useful packages for ML development, see [requirements.txt].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya, good call

* xgboost==1.3.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't tell why it thinks this is a change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm not sure either. Maybe a windows vs unix file ending thing?

@rameshvs rameshvs merged commit 98e913c into master Apr 13, 2021
@rameshvs rameshvs deleted the rameshvs/orbyter-ml-dev-3.4 branch April 13, 2021 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install line_profiler in default ml-dev image
2 participants