Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #70: Support linux-aarch64 and osx-arm64 #71

Merged
merged 4 commits into from Jun 27, 2022
Merged

Fix #70: Support linux-aarch64 and osx-arm64 #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3ecd35d
Fix #70: Support linux-aarch64 and osx-arm64
jonashaag Jun 27, 2022
b587a72
Fix windows
jonashaag Jun 27, 2022
1575adc
Fix windows
jonashaag Jun 27, 2022
23fc0a3
Fix mac
jonashaag Jun 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
44 changes: 28 additions & 16 deletions dist/main/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

44 changes: 28 additions & 16 deletions index.js
View file
Open in desktop
Expand Up @@ -10,24 +10,34 @@ const cache = require('@actions/cache')
const core = require('@actions/core')
const exec = require('@actions/exec')

const MAMBA_PLATFORM = { darwin: 'osx', linux: 'linux', win32: 'win' }[process.platform]
if (!MAMBA_PLATFORM) {
throw Error(`Platform ${process.platform} not supported.`)
}
const PATHS = {
condarc: path.join(os.homedir(), '.condarc'),
bashprofile: path.join(os.homedir(), '.bash_profile'),
bashrc: path.join(os.homedir(), '.bashrc'),
bashrcBak: path.join(os.homedir(), '.bashrc.actionbak'),
micromambaBinFolder: path.join(os.homedir(), 'micromamba-bin'),
micromambaExe: path.join(os.homedir(), 'micromamba-bin', MAMBA_PLATFORM === 'win' ? 'micromamba.exe' : 'micromamba'),
micromambaExe: path.join(os.homedir(), 'micromamba-bin', process.platform === 'win32' ? 'micromamba.exe' : 'micromamba'),
micromambaRoot: path.join(os.homedir(), 'micromamba'),
micromambaPkgs: path.join(os.homedir(), 'micromamba', 'pkgs'),
micromambaEnvs: path.join(os.homedir(), 'micromamba', 'envs')
}

// --- Utils ---

function getCondaArch () {
const arch = {
[['darwin', 'arm64']]: 'osx-arm64',
[['darwin', 'x64']]: 'osx-64',
[['linux', 'x64']]: 'linux-64',
[['linux', 'arm64']]: 'linux-aarch64',
[['win32', 'x64']]: 'win-64'
}[[process.platform, process.arch]]
if (!arch) {
throw Error(`Platform ${process.platform}/${process.arch} not supported.`)
}
return arch
}

function getInputAsArray (name) {
// From https://github.com/actions/cache/blob/main/src/utils/actionUtils.ts
return core
Expand Down Expand Up @@ -57,7 +67,7 @@ function executePwsh (command) {
return executeShell('powershell', '-command', `${command}; exit $LASTEXITCODE`)
}

const executeLoginShell = MAMBA_PLATFORM === 'win' ? executePwsh : executeBashLogin
const executeLoginShell = process.platform === 'win32' ? executePwsh : executeBashLogin

function micromambaCmd (command, logLevel, micromambaExe = 'micromamba') {
return `${micromambaExe} ${command}` + (logLevel ? ` --log-level ${logLevel}` : '')
Expand Down Expand Up @@ -137,7 +147,7 @@ async function installMicromambaPosix (micromambaUrl, logLevel) {
}

await executeBash(`chmod u+x ${PATHS.micromambaExe}`)
if (MAMBA_PLATFORM === 'osx') {
if (process.platform === 'darwin') {
// macos
await executeBash(micromambaCmd('shell init -s bash -p ~/micromamba -y', logLevel, PATHS.micromambaExe))
// TODO need to fix a check in micromamba so that this works
Expand Down Expand Up @@ -237,11 +247,11 @@ async function installMicromamba (inputs, extraChannels) {
if (!fs.existsSync(PATHS.micromambaBinFolder)) {
core.startGroup('Install micromamba ...')
const installer = {
win: installMicromambaWindows,
win32: installMicromambaWindows,
linux: installMicromambaPosix,
osx: installMicromambaPosix
}[MAMBA_PLATFORM]
const micromambaUrl = `${inputs.installerUrl}/${MAMBA_PLATFORM}-64/${inputs.micromambaVersion}`
darwin: installMicromambaPosix
}[process.platform]
const micromambaUrl = `${inputs.installerUrl}/${getCondaArch()}/${inputs.micromambaVersion}`
await installer(micromambaUrl, inputs.logLevel)
core.exportVariable('MAMBA_ROOT_PREFIX', PATHS.micromambaRoot)
core.exportVariable('MAMBA_EXE', PATHS.micromambaExe)
Expand All @@ -256,7 +266,8 @@ async function installMicromamba (inputs, extraChannels) {

function isSelected (item) {
if (/sel\(.*\):.*/gi.test(item)) {
return new RegExp('sel\\(' + MAMBA_PLATFORM + '\\):.*', 'gi').test(item)
const condaPlatform = getCondaArch().split('-')[0]
return new RegExp(`sel\\(${condaPlatform}\\):.*`, 'gi').test(item)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wolfv does Mamba support CPU arch specific selectors like sel(linux-aarch64) or only sel(linux)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only sel(linux) at the moment, sadly.

}
return true
}
Expand All @@ -283,7 +294,7 @@ async function createOrUpdateEnv (envName, envFilePath, extraSpecs, logLevel) {
if (envFilePath) {
cmd += ' -f ' + envFilePath
}
if (MAMBA_PLATFORM === 'win') {
if (process.platform === 'win32') {
await executePwsh(cmd)
} else {
await executeBash(cmd)
Expand Down Expand Up @@ -323,13 +334,14 @@ function determineEnvironmentName (inputs, envFilePath, envYaml) {

async function installEnvironment (inputs, envFilePath, envYaml) {
const envName = determineEnvironmentName(inputs, envFilePath, envYaml)
const defaultCacheKey = `${getCondaArch()} ${today()}`

core.startGroup(`Install environment ${envName} from ${envFilePath || ''} ${inputs.extraSpecs || ''}...`)
let downloadCacheHit, downloadCacheArgs, envCacheHit, envCacheArgs

// Try to load the entire env from cache.
if (inputs.cacheEnv) {
let key = inputs.cacheEnvKey || `${MAMBA_PLATFORM}-${process.arch} ${today()}`
let key = inputs.cacheEnvKey || defaultCacheKey
if (envFilePath) {
key += ' file: ' + sha256Short(fs.readFileSync(envFilePath))
}
Expand All @@ -344,7 +356,7 @@ async function installEnvironment (inputs, envFilePath, envYaml) {
if (shouldTryDownloadCache) {
// Try to restore the download cache.
if (inputs.cacheDownloads) {
const key = inputs.cacheDownloadsKey || `${MAMBA_PLATFORM}-${process.arch} ${today()}`
const key = inputs.cacheDownloadsKey || defaultCacheKey
downloadCacheArgs = [PATHS.micromambaPkgs, `micromamba-pkgs ${key}`]
downloadCacheHit = await tryRestoreCache(...downloadCacheArgs)
}
Expand All @@ -353,7 +365,7 @@ async function installEnvironment (inputs, envFilePath, envYaml) {

// Add micromamba activate to profile
const autoactivateCmd = `micromamba activate ${envName};`
if (MAMBA_PLATFORM === 'win') {
if (process.platform === 'win32') {
const powershellAutoActivateEnv = `if (!(Test-Path $profile))
{
New-Item -path $profile -type "file" -value "${autoactivateCmd}"
Expand Down