Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#5][Backend] As a User, I can sign up and sign in/out with a username and password #33

Merged
merged 57 commits into from Jun 16, 2021

Conversation

malparty
Copy link
Owner

@malparty malparty commented Jun 10, 2021

#5 [Backend] As a User, I can sign up and sign in/out with a username and password

What happened

Implementation of Devise, to get Web authentication.

Insight

  • sign up (/users/sign_up -- auto redirected when no logged)
  • sign in ( /users/sign_in)
  • sign out (button on home page once logged)
  • edit profile ( /users/edit)

Proof Of Work

image image
image image
image

malparty and others added 27 commits June 8, 2021 18:05
Bring Unit Test config to this branch
Co-authored-by: Junan Chakma <junan.cs@gmail.com>
Co-authored-by: Junan Chakma <junan.cs@gmail.com>
@github-actions
Copy link

github-actions bot commented Jun 10, 2021

3 Errors
🚫 Brakeman static analysis detected issues in the code. If this is a false positive, mark it as such.
🚫 Code coverage data not found
🚫 Undercover: coverage report cannot be found.

BRAKEMAN REPORT

Application path Rails version Brakeman version Started at Duration
/home/runner/work/google-search-ruby/google-search-ruby 6.1.3.1 5.0.1 2021-06-14 10:43:58 +0000 2.031552888 seconds
Checks performed
BasicAuth, BasicAuthTimingAttack, CSRFTokenForgeryCVE, ContentTag, CookieSerialization, CreateWith, CrossSiteScripting, DefaultRoutes, Deserialize, DetailedExceptions, DigestDoS, DynamicFinders, EscapeFunction, Evaluation, Execute, FileAccess, FileDisclosure, FilterSkipping, ForgerySetting, HeaderDoS, I18nXSS, JRubyXML, JSONEncoding, JSONEntityEscape, JSONParsing, LinkTo, LinkToHref, MailTo, MassAssignment, MimeTypeDoS, ModelAttrAccessible, ModelAttributes, ModelSerialize, NestedAttributes, NestedAttributesBypass, NumberToCurrency, PageCachingCVE, PermitAttributes, QuoteTableName, Redirect, RegexDoS, Render, RenderDoS, RenderInline, ResponseSplitting, RouteDoS, SQL, SQLCVEs, SSLVerify, SafeBufferManipulation, SanitizeMethods, SelectTag, SelectVulnerability, Send, SendFile, SessionManipulation, SessionSettings, SimpleFormat, SingleQuotes, SkipBeforeFilter, SprocketsPathTraversal, StripTags, SymbolDoSCVE, TemplateInjection, TranslateBug, UnsafeReflection, UnsafeReflectionMethods, ValidationRegex, VerbConfusion, WithoutProtection, XMLDoS, YAMLParsing

SUMMARY

Scanned/Reported Total
Controllers 2
Models 2
Templates 17
Errors 0
Security Warnings 1 (0)
Warning Type Total
Cross-Site Scripting 1

SECURITY WARNINGS

Confidence Class Method Warning Type Message
Medium Cross-Site Scripting loofah gem 2.10.0 is vulnerable (CVE-2018-8048). Upgrade to 2.2.1 near line 214

Generated by 🚫 Danger

@junan
Copy link
Contributor

junan commented Jun 14, 2021

@malparty I think youn can rebase with latest develop branch with your local branch so that the those already merged(to development) changes will not show this PR and it helps reviewers to review PRs. Currently many new changes, those already exist in the develop branch.

Gemfile Show resolved Hide resolved
db/seeds.rb Outdated Show resolved Hide resolved
Product backlog automation moved this from In code review to Ready for QA Jun 15, 2021
@malparty malparty merged commit ff6f012 into develop Jun 16, 2021
@malparty malparty mentioned this pull request Jun 21, 2021
@malparty malparty moved this from Ready for QA to Completed in Product backlog Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend Feature priority: normal $user-login Authentication: Sign up, sign in and sign out @0.2.0 First usable release.
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants