Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2] Configure unit test automations #31

Merged
merged 1 commit into from Jun 8, 2021
Merged

Conversation

malparty
Copy link
Owner

@malparty malparty commented Jun 8, 2021

#2 Configure unit test automations

What happened

Enable GitHub Actions to run Tests (unit tests) automatically from the Test workflow.

Insight

  • Setup the right environment variables on Test workflow. It will use GitHub Package Docker registry.
  • Configure GitHub secrets with DOCKER_REGISTRY_HOST (done in GitHub, not in the source code)
  • Run the workflow and confirm we have all 8x tests well executed.

Proof Of Work

Before:

image

After:

image
image

@malparty malparty added @0.1.0 Initial release !ci-cd Work made on task automations for integration & deployment Chore priority: normal labels Jun 8, 2021
@malparty malparty added this to the 0.1.0 milestone Jun 8, 2021
@malparty malparty self-assigned this Jun 8, 2021
@malparty malparty added this to In development in Product backlog via automation Jun 8, 2021
@malparty malparty moved this from In development to In code review in Product backlog Jun 8, 2021
@github-actions
Copy link

github-actions bot commented Jun 8, 2021

3 Errors
🚫 Brakeman static analysis detected issues in the code. If this is a false positive, mark it as such.
🚫 Code coverage data not found
🚫 Undercover: coverage report cannot be found.

BRAKEMAN REPORT

Application path Rails version Brakeman version Started at Duration
/home/runner/work/google-search-ruby/google-search-ruby 6.1.3.1 5.0.1 2021-06-08 09:02:58 +0000 1.657341269 seconds
Checks performed
BasicAuth, BasicAuthTimingAttack, CSRFTokenForgeryCVE, ContentTag, CookieSerialization, CreateWith, CrossSiteScripting, DefaultRoutes, Deserialize, DetailedExceptions, DigestDoS, DynamicFinders, EscapeFunction, Evaluation, Execute, FileAccess, FileDisclosure, FilterSkipping, ForgerySetting, HeaderDoS, I18nXSS, JRubyXML, JSONEncoding, JSONEntityEscape, JSONParsing, LinkTo, LinkToHref, MailTo, MassAssignment, MimeTypeDoS, ModelAttrAccessible, ModelAttributes, ModelSerialize, NestedAttributes, NestedAttributesBypass, NumberToCurrency, PageCachingCVE, PermitAttributes, QuoteTableName, Redirect, RegexDoS, Render, RenderDoS, RenderInline, ResponseSplitting, RouteDoS, SQL, SQLCVEs, SSLVerify, SafeBufferManipulation, SanitizeMethods, SelectTag, SelectVulnerability, Send, SendFile, SessionManipulation, SessionSettings, SimpleFormat, SingleQuotes, SkipBeforeFilter, SprocketsPathTraversal, StripTags, SymbolDoSCVE, TemplateInjection, TranslateBug, UnsafeReflection, UnsafeReflectionMethods, ValidationRegex, VerbConfusion, WithoutProtection, XMLDoS, YAMLParsing

SUMMARY

Scanned/Reported Total
Controllers 1
Models 1
Templates 2
Errors 0
Security Warnings 1 (0)
Warning Type Total
Cross-Site Scripting 1

SECURITY WARNINGS

Confidence Class Method Warning Type Message
Medium Cross-Site Scripting loofah gem 2.10.0 is vulnerable (CVE-2018-8048). Upgrade to 2.2.1 near line 212

Generated by 🚫 Danger

@malparty malparty linked an issue Jun 8, 2021 that may be closed by this pull request
Product backlog automation moved this from In code review to Ready for QA Jun 8, 2021
@ankitkalia1195
Copy link
Collaborator

@malparty Why is this one failing, is there as issue from rails template
Uploading Screen Shot 2564-06-08 at 15.25.26.png…

@malparty
Copy link
Owner Author

malparty commented Jun 8, 2021

@malparty Why is this one failing, is there as issue from rails template

@ankitkalia1195 it's normal, the templates provides you with .github/README.md which provides all guidances in order to make it run. The template does not chose for us which Docker Registry we will use, thus we need to configure it.

@malparty malparty closed this Jun 8, 2021
Product backlog automation moved this from Ready for QA to Completed Jun 8, 2021
@malparty malparty reopened this Jun 8, 2021
Product backlog automation moved this from Completed to In development Jun 8, 2021
@malparty malparty moved this from In development to In code review in Product backlog Jun 8, 2021
Product backlog automation moved this from In code review to Ready for QA Jun 8, 2021
@malparty malparty merged commit 7043772 into develop Jun 8, 2021
Product backlog automation moved this from Ready for QA to Completed Jun 8, 2021
@malparty malparty deleted the chore/setup-unit-tests branch June 8, 2021 10:39
@malparty malparty moved this from Completed to Ready for QA in Product backlog Jun 8, 2021
@malparty malparty mentioned this pull request Jun 11, 2021
@malparty malparty moved this from Ready for QA to Completed in Product backlog Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore !ci-cd Work made on task automations for integration & deployment priority: normal @0.1.0 Initial release
Projects
Development

Successfully merging this pull request may close these issues.

Configure unit test automations
3 participants