#1 Setup Rails template #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,5 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| def sanitize(html) | |||
There was a problem hiding this comment.
| Doesn't depend on instance state (maybe move it to another class?) |
|
PR title should match the issue title. #1 Setup Rails template |
| end | ||
|
|
||
| def extract_locale_from_param | ||
| return params[:locale] if I18n.locale_available?(params[:locale]) |
There was a problem hiding this comment.
| Calls 'params[:locale]' 2 times |
|
|
||
| private | ||
|
|
||
| def default_url_options |
There was a problem hiding this comment.
| Doesn't depend on instance state (maybe move it to another class?) |
| private | ||
|
|
||
| def default_url_options | ||
| { locale: I18n.locale == I18n.default_locale ? nil : I18n.locale } |
There was a problem hiding this comment.
| Calls 'i18n.locale' 2 times |
| # Usage for Rails: | ||
| # in config/environments/test.rb | ||
| # config.middleware.use Rack::NoAnimations | ||
| class NoAnimations |
There was a problem hiding this comment.
| Assumes too much for instance variable '@Body' |
| # Usage for Rails: | ||
| # in config/environments/test.rb | ||
| # config.middleware.use Rack::NoAnimations | ||
| class NoAnimations |
There was a problem hiding this comment.
| Assumes too much for instance variable '@headers' |
| # Usage for Rails: | ||
| # in config/environments/test.rb | ||
| # config.middleware.use Rack::NoAnimations | ||
| class NoAnimations |
There was a problem hiding this comment.
| Assumes too much for instance variable '@status' |
| @app = app | ||
| end | ||
|
|
||
| def call(env) |
There was a problem hiding this comment.
| Has approx 7 statements |
| response = Rack::Response.new([], @status, @headers) | ||
|
|
||
| @body.each { |fragment| response.write inject(fragment) } | ||
| @body.close if @body.respond_to?(:close) |
There was a problem hiding this comment.
| Manually dispatches method call |
| # rubocop:disable Metrics/MethodLength | ||
| # rubocop:disable Naming/HeredocDelimiterNaming | ||
| # rubocop:disable Layout/HeredocIndentation | ||
| def inject(fragment) |
There was a problem hiding this comment.
| Doesn't depend on instance state (maybe move it to another class?) |
| end | ||
| end | ||
|
|
||
| def configure_vcr_with_options(example, vcr_options) |
There was a problem hiding this comment.
| Has approx 8 statements |
| end | ||
|
|
||
| def configure_vcr_with_options(example, vcr_options) | ||
| cassette_options = vcr_options[:options] || {} |
There was a problem hiding this comment.
| Refers to 'vcr_options' more than self (maybe move it to another class?) |
|
|
||
| def configure_vcr_with_options(example, vcr_options) | ||
| cassette_options = vcr_options[:options] || {} | ||
| vcr_cassettes = vcr_options[:cassettes] || Array(vcr_options[:cassette]) |
There was a problem hiding this comment.
| Refers to 'vcr_options' more than self (maybe move it to another class?) |
| def configure_vcr_with_options(example, vcr_options) | ||
| cassette_options = vcr_options[:options] || {} | ||
| vcr_cassettes = vcr_options[:cassettes] || Array(vcr_options[:cassette]) | ||
| cassette_group = vcr_options[:group] |
There was a problem hiding this comment.
| Refers to 'vcr_options' more than self (maybe move it to another class?) |
BRAKEMAN REPORT
SUMMARY
SECURITY WARNINGS
Generated by 🚫 Danger |
|
@malparty As this PR is ready for review, we can move the related task into the |
junan
reviewed
Jun 8, 2021
junan
reviewed
Jun 8, 2021
junan
reviewed
Jun 8, 2021
ankitkalia1195
approved these changes
Jun 8, 2021
…Junan issue on rails template
junan
approved these changes
Jun 8, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1 Setup Rails template
What happened 👀
Basic deployment of Nimble Rails template & simple README.md update.
This is the start point for my project and enabling me to move forward.
Insight 📝
Rails Template has been configured with 2 addons:
Proof Of Work 📹