[#7] Add attr_reader for gogole parser service

malparty · Jun 30, 2021 · d8e6042 · d8e6042
1 parent e0a42da
commit d8e6042
Showing 1 changed file with 12 additions and 11 deletions.
diff --git a/app/services/google/parser_service.rb b/app/services/google/parser_service.rb
@@ -14,10 +14,10 @@ def initialize(html_response:)
       @document = Nokogiri::HTML.parse(html_response)
 
       # Add a class to all AdWords link for easier manipulation
-      @document.css('div[data-text-ad] a[data-ved]').add_class(ADWORDS_CLASS)
+      document.css('div[data-text-ad] a[data-ved]').add_class(ADWORDS_CLASS)
 
       # Mark footer links to identify them
-      @document.css('#footcnt a').add_class('footer-links')
+      document.css('#footcnt a').add_class('footer-links')
     end
 
     # Parse html data and return a hash with the results
@@ -30,39 +30,40 @@ def call
         non_ads_result_count: non_ads_result_count,
         non_ads_url: non_ads_url,
         total_link_count: total_link_count,
-        html: @html
+        html: html
       }
     end
 
     private
 
+    attr_reader :html, :document
+
     def ads_top_count
-      @document.css("##{AD_CONTAINER_ID} .#{ADWORDS_CLASS}").count
+      document.css("##{AD_CONTAINER_ID} .#{ADWORDS_CLASS}").count
     end
 
     def ads_page_count
-      @document.css(".#{ADWORDS_CLASS}").count
+      document.css(".#{ADWORDS_CLASS}").count
     end
 
     def ads_top_url
-      # data-ved enables to filter "role=list" (sub links) items
-      @document.css("##{AD_CONTAINER_ID} .#{ADWORDS_CLASS}").map { |a_tag| a_tag['href'] }
+      document.css("##{AD_CONTAINER_ID} .#{ADWORDS_CLASS}").map { |a_tag| a_tag['href'] }
     end
 
     def ads_page_url
-      @document.css(".#{ADWORDS_CLASS}").map { |a_tag| a_tag['href'] }
+      document.css(".#{ADWORDS_CLASS}").map { |a_tag| a_tag['href'] }
     end
 
     def non_ads_result_count
-      @document.css(NON_ADS_RESULT_SELECTOR).count
+      document.css(NON_ADS_RESULT_SELECTOR).count
     end
 
     def non_ads_url
-      @document.css(NON_ADS_RESULT_SELECTOR).map { |a_tag| a_tag['href'] }
+      document.css(NON_ADS_RESULT_SELECTOR).map { |a_tag| a_tag['href'] }
     end
 
     def total_link_count
-      @document.css('a').count
+      document.css('a').count
     end
   end
 end