Skip to content

Commit

Permalink
[#7] Rename GoogleService namespace in Google
Browse files Browse the repository at this point in the history
  • Loading branch information
malparty committed Jun 30, 2021
1 parent 9d31857 commit 5462897
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 10 deletions.
@@ -1,6 +1,6 @@
# frozen_string_literal: true

module GoogleService
module Google
class ParserService
require 'nokogiri'

Expand Down
2 changes: 1 addition & 1 deletion spec/services/google_service/client_service_spec.rb
Expand Up @@ -2,7 +2,7 @@

require 'rails_helper'

RSpec.describe GoogleService::ClientService, type: :service do
RSpec.describe Google::ClientService, type: :service do
context 'when querying a simple keyword' do
it 'returns an HTTParty Response', vcr: 'google_search' do
result = described_class.query(FFaker::Lorem.word)
Expand Down
16 changes: 8 additions & 8 deletions spec/services/google_service/parser_service_spec.rb
Expand Up @@ -2,49 +2,49 @@

require 'rails_helper'

RSpec.describe GoogleService::ParserService, type: :service do
RSpec.describe Google::ParserService, type: :service do
context 'when parsing a page having 1 top ad' do
it 'counts exactly 1 top ad', vcr: 'google_search_top_ads_1' do
result = GoogleService::ClientService.new('squarespace').call
result = Google::ClientService.new('squarespace').call

expect(described_class.new(result).ads_top_count).to eq(1)
end
end

context 'when parsing a page having 3 top ads, 3 bottom ads and 14 non ad links' do
it 'counts exactly 3 top ads', vcr: 'google_search_top_ads_6' do
result = GoogleService::ClientService.new('vpn').call
result = Google::ClientService.new('vpn').call

expect(described_class.new(result).ads_top_count).to eq(3)
end

it 'counts exactly 6 ads in total', vcr: 'google_search_top_ads_6' do
result = GoogleService::ClientService.new('vpn').call
result = Google::ClientService.new('vpn').call

expect(described_class.new(result).ads_page_count).to eq(6)
end

it 'finds exactly the 3 top ads urls', vcr: 'google_search_top_ads_6' do
result = GoogleService::ClientService.new('vpn').call
result = Google::ClientService.new('vpn').call

expect(described_class.new(result).ads_top_url).to contain_exactly('https://cloud.google.com/free', 'https://www.expressvpn.com/', 'https://www.top10vpn.com/best-vpn-for-vietnam/')
end

it 'counts exactly 14 non ad results', vcr: 'google_search_top_ads_6' do
result = GoogleService::ClientService.new('vpn').call
result = Google::ClientService.new('vpn').call

expect(described_class.new(result).non_ads_result_count).to eq(14)
end

it 'gets 14 results', vcr: 'google_search_top_ads_6' do
result = GoogleService::ClientService.new('vpn').call
result = Google::ClientService.new('vpn').call

expect(described_class.new(result).non_ads_url.count).to eq(14)
end

it 'gets exactly 113 links', vcr: 'google_search_top_ads_6' do
# Counted from cassette html raw code
result = GoogleService::ClientService.new('vpn').call
result = Google::ClientService.new('vpn').call

expect(described_class.new(result).total_link_count).to eq(113)
end
Expand Down

0 comments on commit 5462897

Please sign in to comment.