[#7] Implement ads_top_url

malparty · Jun 15, 2021 · 333e515 · 333e515
1 parent bc141b7
commit 333e515
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/app/services/google_service/parser_service.rb b/app/services/google_service/parser_service.rb
@@ -28,7 +28,8 @@ def ads_page_count
     end
 
     def ads_top_url
-
+      # data-ved enables to filter "role=list" (sub links) items
+      @document.css('#tads div[data-text-ad] a[data-ved]').map { |a_tag| a_tag['href'] }
     end
 
     def ads_page_url

diff --git a/spec/services/google_service/parser_service_spec.rb b/spec/services/google_service/parser_service_spec.rb
@@ -33,5 +33,14 @@
       expect(described_class.new(result).ads_page_count).to eq(6)
     end
 
+    it 'find 3 different top ads url' do
+      result = nil
+      VCR.use_cassette('google_search_top_ads_6') do
+        result = GoogleService::ClientService.query('vpn')
+      end
+
+      expect(described_class.new(result).ads_top_url).to contain_exactly('https://cloud.google.com/free','https://www.expressvpn.com/', 'https://www.top10vpn.com/best-vpn-for-vietnam/')
+    end
+
   end
 end