cr fixes (infection#658)

majkel89 · Apr 1, 2019 · 21cddd8 · 21cddd8
1 parent 77e318c
commit 21cddd8
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 17 deletions.
diff --git a/composer.json b/composer.json
@@ -60,8 +60,7 @@
         "symfony/process": "3.4.2"
     },
     "require-dev": {
-        "phpunit/phpunit": "^7.5",
-        "ext-bcmath": "*"
+        "phpunit/phpunit": "^7.5"
     },
     "config": {
         "platform": {

diff --git a/composer.lock b/composer.lock
diff --git a/devTools/Dockerfile-php71-xdebug b/devTools/Dockerfile-php71-xdebug
@@ -1,7 +1,6 @@
 FROM php:7.1-cli
 
-RUN pecl install xdebug && docker-php-ext-enable xdebug && \
-    docker-php-ext-install -j$(nproc) bcmath
+RUN pecl install xdebug && docker-php-ext-enable xdebug
 RUN apt-get update && apt-get install -y --no-install-recommends \
     expect git zip \
     && rm -rf /var/lib/apt/lists/*

diff --git a/devTools/Dockerfile-php72-xdebug b/devTools/Dockerfile-php72-xdebug
@@ -1,7 +1,6 @@
 FROM php:7.2-cli
 
-RUN pecl install xdebug && docker-php-ext-enable xdebug && \
-    docker-php-ext-install -j$(nproc) bcmath
+RUN pecl install xdebug && docker-php-ext-enable xdebug
 RUN apt-get update && apt-get install -y --no-install-recommends \
     expect git zip \
     && rm -rf /var/lib/apt/lists/*

diff --git a/devTools/Dockerfile-php73-xdebug b/devTools/Dockerfile-php73-xdebug
@@ -1,7 +1,6 @@
 FROM php:7.3-rc-cli
 
-RUN pecl install xdebug-beta && docker-php-ext-enable xdebug && \
-    docker-php-ext-install -j$(nproc) bcmath
+RUN pecl install xdebug-beta && docker-php-ext-enable xdebug
 RUN apt-get update && apt-get install -y --no-install-recommends \
     expect git zip \
     && rm -rf /var/lib/apt/lists/*

diff --git a/src/Mutator/Extensions/BCMath.php b/src/Mutator/Extensions/BCMath.php
@@ -72,9 +72,7 @@ protected function mutatesNode(Node $node): bool
             return false;
         }
 
-        $functionName = $node->name->toLowerString();
-
-        return isset($this->converters[$functionName]) && \function_exists($functionName);
+        return isset($this->converters[$node->name->toLowerString()]);
     }
 
     private function setupConverters(array $functionsMap): void
@@ -109,7 +107,7 @@ private function setupConverters(array $functionsMap): void
             ),
         ];
 
-        $functionsToRemove = \array_filter($functionsMap, static function ($isOn) {
+        $functionsToRemove = \array_filter($functionsMap, static function (bool $isOn): bool {
             return !$isOn;
         });
 

diff --git a/src/Mutator/Extensions/MBString.php b/src/Mutator/Extensions/MBString.php
@@ -98,7 +98,7 @@ private function setupConverters(array $functionsMap): void
             'mb_convert_case' => $this->mapConvertCase(),
         ];
 
-        $functionsToRemove = \array_filter($functionsMap, static function ($isOn) {
+        $functionsToRemove = \array_filter($functionsMap, static function (bool $isOn): bool {
             return !$isOn;
         });