Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(operator): add webhook to auto mutate Deployment as target #539

Draft
wants to merge 33 commits into
base: master
Choose a base branch
from

Conversation

aslakknutsen
Copy link
Member

@aslakknutsen aslakknutsen commented Sep 25, 2020

A mutating webhook that will update a Deployment with the Labels of the 'target' Deployment
as defined by the ike.target label. This allows for traffic to be routed to Deployments created by
3. party apps like Che Workspaces.

Fixes #528

  • CA Bundle creation for non Openshift clusters
  • optional mutation install flag?
  • mutation local install with namespace selector
  • dynamically resolve Lables, ConvertRefStatus..?
  • DryRun logic
  • Dynamic session name
  • Finalize Che Workspace integration params etc
  • Move to annotations from labels
  • Add "session name" annotation on Deployment for Deletion
  • e2e test case - simulate Che Deployment

@aslakknutsen
Copy link
Member Author

/ok-to-test

@aslakknutsen
Copy link
Member Author

/test openshift

1 similar comment
@aslakknutsen
Copy link
Member Author

/test openshift

@alien-ike
Copy link
Collaborator

@aslakknutsen: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
e2e-tests-openshift fc3df7e link /test openshift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/operator Component: Operator service kind/enhancement Kind: New feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should be able to manipulate the creation of a Deployment
2 participants