Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should be able to manipulate the creation of a Deployment #528

Open
aslakknutsen opened this issue Sep 16, 2020 · 0 comments · May be fixed by #539
Open

Should be able to manipulate the creation of a Deployment #528

aslakknutsen opened this issue Sep 16, 2020 · 0 comments · May be fixed by #539
Assignees
@aslakknutsen
Labels
component/ide Component: IDE Integration component/operator Component: Operator service kind/enhancement Kind: New feature or improvement

Comments

@aslakknutsen
Copy link
Member

Why

Che Server will launch a Workspace by creating a Deployment object. For Ike to route the traffic from a specific Service to this new Deployment we need the ability to manipulate the Deployment object.

What

A MutatingAdmission WebHook should give us the option to add the target Deployment labels to the Workspace Deployment and by that route traffic to it.

Only mutate Deployments that are labeled ike.target=x
@aslakknutsen aslakknutsen added component/ide Component: IDE Integration component/operator Component: Operator service kind/enhancement Kind: New feature or improvement labels Sep 16, 2020
@aslakknutsen aslakknutsen self-assigned this Sep 22, 2020
aslakknutsen added a commit that referenced this issue Sep 22, 2020
@aslakknutsen
feat(operator): add deployment mutation hook
d75f4b4 
fixes #528
aslakknutsen added a commit that referenced this issue Sep 24, 2020
@aslakknutsen
feat(client): allow client to wait for different conditions based on …
8ac3142 
…usage

In a normal cli setting we're looking for a Deployment or a DeploymentConfig,
but with the che integration the Deployment already exists so we need to be
able to wait for something else.

related to #528
@aslakknutsen aslakknutsen mentioned this issue Sep 24, 2020
Merged
bartoszmajsak pushed a commit that referenced this issue Sep 24, 2020
@aslakknutsen
feat(client): make client wait condition configurable (#531)
56a26da 
Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com>

Related to #528
aslakknutsen added a commit that referenced this issue Sep 25, 2020
@aslakknutsen
feat(operator): add deployment mutation hook
7c40a40 
fixes #528
aslakknutsen added a commit that referenced this issue Sep 25, 2020
@aslakknutsen
feat(operator): add deployment mutation hook
493c5be 
fixes #528
@aslakknutsen aslakknutsen linked a pull request Sep 25, 2020 that will close this issue
Draft
10 tasks
aslakknutsen added a commit that referenced this issue Oct 7, 2020
@aslakknutsen
feat(operator): add deployment mutation hook
20ea961 
fixes #528
@aslakknutsen aslakknutsen mentioned this issue Nov 13, 2020
Merged
aslakknutsen added a commit that referenced this issue Nov 17, 2020
@aslakknutsen
feat: add health and readiness endpoints + probe config
d642557 
Leader election can take a few more seconds so ensure
readiness is not done until leader election is done.

Related to #528
Fixes #546
Fixes #547
aslakknutsen added a commit that referenced this issue Nov 18, 2020
@aslakknutsen
feat(operator): add deployment mutation hook
97e0d48 
fixes #528
aslakknutsen added a commit that referenced this issue Nov 27, 2020
@aslakknutsen
feat(operator): add deployment mutation hook
b2f3001 
fixes #528
@aslakknutsen aslakknutsen modified the milestone: v0.0.5 Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aslakknutsen aslakknutsen

Labels
component/ide Component: IDE Integration component/operator Component: Operator service kind/enhancement Kind: New feature or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(operator): add webhook to auto mutate Deployment as target maistra/istio-workspace
1 participant
@aslakknutsen