Remove hard dependency on logrus for logging #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanejohnson
force-pushed
the
feature/modular_logging
branch
2 times, most recently
from
73554cb
to
7f484e3
Compare
|
So this will slow logging down slightly if using the LogrusLogger versus native logrus, but from a quick POC doing a zerolog implementation as a Logger I get considerably better results: Here is a link to the implementation if you're curious. https://github.com/nathanejohnson/groupcache/blob/feature/zerolog/logger.go#L98 |
nathanejohnson
force-pushed
the
feature/modular_logging
branch
2 times, most recently
from
41547e8
to
4e495db
Compare
Provides backwards compatibility with existing logrus via SetLogger() method Introduces a Logger interface that others can implement for other structured loggers such as zerolog. Add SetLoggerFromLogger method that allows caller to pass in an implementation of the new Logger interface. Bumps the golang.org/x/sys dependency since tests fail to run on go 1.18 with the old version. adding a test case for LogrusLogger adding benchmark, add WithFields method because it's a lot faster apparently
nathanejohnson
force-pushed
the
feature/modular_logging
branch
from
4e495db
to
8c6aae6
Compare
|
for what it's worth, I've opened a PR with upstream logrus around the x/sys dep: |
thrawn01
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes hard dependency on logrus for logging, while providing
backwards compatibility via the SetLogger method.
Introduces a Logger interface that others can implement for other
structured loggers such as zerolog.
Bumps the golang.org/x/sys dependency since tests fail to run on go 1.18 with the old version.