refactor(orc8r): Omit nil-checks for multierror.Append calls #12666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
Signed-off-by: Sebastian Wolf <sebastian.wolf@tngtech.com>
wolfseb
force-pushed
the
cleanup-multierror
branch
from
b97459c
to
c23375c
Compare
| if err != nil { | ||
| errs = multierror.Append(errs, errors.Wrapf(err, "collect garbage for table %+v", tableName)) | ||
| } | ||
| errs = multierror.Append(errs, errors.Wrapf(err, "collect garbage for table %+v", tableName)) |
There was a problem hiding this comment.
Removing this nil check might make things more complicated if we intend to get rid of errors.Wrapf later? We will have to reintroduce it then, I suppose.
There was a problem hiding this comment.
Yes, you are right. Since it is merged now we'll have to change it in the PR that gets rid of Wrapf (#12682); I will arrange that.
uri200
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
multierror.Appendalready handles nil-checks, so checking before calling it is unnecessary, except when the error is formatted with e.g.fmt.Errorf. This PR follows this discussion.Test Plan
Run unit tests
Additional Information