Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(orc8r): Replace multi.go with hashicorp/go-multierror module #12627

Merged
merged 3 commits into from
May 13, 2022
Merged

refactor(orc8r): Replace multi.go with hashicorp/go-multierror module #12627

merged 3 commits into from
May 13, 2022
+98 −346

Commits on May 13, 2022

  1. remove files that are either unused or replaced in this PR 

    remove grpc_to_http.go because it is unused

Signed-off-by: Alexander zur Bonsen <alexander.zur.bonsen@tngtech.com>

deleted multi_error_test.go

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>

remove multi.go

Signed-off-by: Alexander zur Bonsen <alexander.zur.bonsen@tngtech.com>
    @alexzurbonsen
    alexzurbonsen committed May 13, 2022
    Configuration menu
    Copy the full SHA
    cb54975 View commit details
    Browse the repository at this point in the history

  2. replace magma multierror with hashicorp/multierror 

    Author: Marco Pfirrmann <marco.pfirrmann@tngtech.com>
Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>

changed merrors.Multi to multierrors.Error

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>

certifier.go: changed merrors package to hashicorp/multierrors

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>

introduce missing null checks

Signed-off-by: Alexander zur Bonsen <alexander.zur.bonsen@tngtech.com>

renaming multiError variables for better readability

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>

multierror.Append is assigned to the errs variable

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>

remove pkg/errors package from this PR and use std lib

Signed-off-by: Alexander zur Bonsen <alexander.zur.bonsen@tngtech.com>

include nil check in wrapper in indexer_servicer.go

signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>
    @alexzurbonsen
    alexzurbonsen committed May 13, 2022
    Configuration menu
    Copy the full SHA
    58e6193 View commit details
    Browse the repository at this point in the history

  3. go mod tidy in all modules 

    Signed-off-by: Alexander zur Bonsen <alexander.zur.bonsen@tngtech.com>
    @alexzurbonsen
    alexzurbonsen committed May 13, 2022
    Configuration menu
    Copy the full SHA
    f2aa99a View commit details
    Browse the repository at this point in the history