-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add web3modal extension #742
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So clean, love it
this.sdk.thirdPartyWallet.isConnected && | ||
payload.method !== MagicPayloadMethod.IntermediaryEvent && | ||
payload.method !== MagicPayloadMethod.NFTCheckout && | ||
payload.method !== MagicPayloadMethod.Login |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this implementation might encounter forward compatible issue in the future. Is it possible to list the events that needs to be routed?
📦 Pull Request
[Provide a general summary of the pull request here.]
Looks like a huge PR by the number of files modified, but they are mostly test files.
Changes summary
request
function to route payload to third party wallet if connected✅ Fixed Issues
🚨 Test instructions
[Describe any additional context required to test the PR/feature/bug fix.]
Please 🚨 ONLY ADD ONE 🚨 of the following labels, failing to do so may lead to adverse versioning of your changes when published:
patch
: Bug Fix?minor
: New Feature?major
: Breaking Change?skip-release
: It's unnecessary to publish this change.Special Note
Please avoid adding any of the
Priority
labels as they conflict with the labels above ☝️📦 Published PR as canary version:
Canary Versions
✨ Test out this PR locally via:
npm install @magic-ext/algorand@23.0.5-canary.742.9420309456.0 npm install @magic-ext/aptos@11.0.5-canary.742.9420309456.0 npm install @magic-ext/avalanche@23.0.5-canary.742.9420309456.0 npm install @magic-ext/bitcoin@23.0.5-canary.742.9420309456.0 npm install @magic-ext/conflux@21.0.5-canary.742.9420309456.0 npm install @magic-ext/cosmos@23.0.5-canary.742.9420309456.0 npm install @magic-ext/ed25519@19.0.5-canary.742.9420309456.0 npm install @magic-ext/flow@23.0.5-canary.742.9420309456.0 npm install @magic-ext/gdkms@11.0.5-canary.742.9420309456.0 npm install @magic-ext/harmony@23.0.5-canary.742.9420309456.0 npm install @magic-ext/icon@23.0.5-canary.742.9420309456.0 npm install @magic-ext/near@23.0.5-canary.742.9420309456.0 npm install @magic-ext/oauth@22.0.6-canary.742.9420309456.0 npm install @magic-ext/oauth2@9.0.5-canary.742.9420309456.0 npm install @magic-ext/oidc@11.0.5-canary.742.9420309456.0 npm install @magic-ext/polkadot@23.0.5-canary.742.9420309456.0 npm install @magic-ext/react-native-bare-oauth@25.0.5-canary.742.9420309456.0 npm install @magic-ext/react-native-expo-oauth@25.0.5-canary.742.9420309456.0 npm install @magic-ext/solana@25.1.3-canary.742.9420309456.0 npm install @magic-ext/sui@0.1.4-canary.742.9420309456.0 npm install @magic-ext/taquito@20.0.5-canary.742.9420309456.0 npm install @magic-ext/terra@20.0.5-canary.742.9420309456.0 npm install @magic-ext/tezos@23.0.5-canary.742.9420309456.0 npm install @magic-ext/web3modal-ethers5@0.1.1-canary.742.9420309456.0 npm install @magic-ext/webauthn@22.0.5-canary.742.9420309456.0 npm install @magic-ext/zilliqa@23.0.5-canary.742.9420309456.0 npm install @magic-sdk/commons@24.0.5-canary.742.9420309456.0 npm install @magic-sdk/pnp@22.0.7-canary.742.9420309456.0 npm install @magic-sdk/provider@28.0.5-canary.742.9420309456.0 npm install @magic-sdk/react-native-bare@29.0.5-canary.742.9420309456.0 npm install @magic-sdk/react-native-expo@29.0.5-canary.742.9420309456.0 npm install @magic-sdk/types@24.0.4-canary.742.9420309456.0 npm install magic-sdk@28.0.6-canary.742.9420309456.0 # or yarn add @magic-ext/algorand@23.0.5-canary.742.9420309456.0 yarn add @magic-ext/aptos@11.0.5-canary.742.9420309456.0 yarn add @magic-ext/avalanche@23.0.5-canary.742.9420309456.0 yarn add @magic-ext/bitcoin@23.0.5-canary.742.9420309456.0 yarn add @magic-ext/conflux@21.0.5-canary.742.9420309456.0 yarn add @magic-ext/cosmos@23.0.5-canary.742.9420309456.0 yarn add @magic-ext/ed25519@19.0.5-canary.742.9420309456.0 yarn add @magic-ext/flow@23.0.5-canary.742.9420309456.0 yarn add @magic-ext/gdkms@11.0.5-canary.742.9420309456.0 yarn add @magic-ext/harmony@23.0.5-canary.742.9420309456.0 yarn add @magic-ext/icon@23.0.5-canary.742.9420309456.0 yarn add @magic-ext/near@23.0.5-canary.742.9420309456.0 yarn add @magic-ext/oauth@22.0.6-canary.742.9420309456.0 yarn add @magic-ext/oauth2@9.0.5-canary.742.9420309456.0 yarn add @magic-ext/oidc@11.0.5-canary.742.9420309456.0 yarn add @magic-ext/polkadot@23.0.5-canary.742.9420309456.0 yarn add @magic-ext/react-native-bare-oauth@25.0.5-canary.742.9420309456.0 yarn add @magic-ext/react-native-expo-oauth@25.0.5-canary.742.9420309456.0 yarn add @magic-ext/solana@25.1.3-canary.742.9420309456.0 yarn add @magic-ext/sui@0.1.4-canary.742.9420309456.0 yarn add @magic-ext/taquito@20.0.5-canary.742.9420309456.0 yarn add @magic-ext/terra@20.0.5-canary.742.9420309456.0 yarn add @magic-ext/tezos@23.0.5-canary.742.9420309456.0 yarn add @magic-ext/web3modal-ethers5@0.1.1-canary.742.9420309456.0 yarn add @magic-ext/webauthn@22.0.5-canary.742.9420309456.0 yarn add @magic-ext/zilliqa@23.0.5-canary.742.9420309456.0 yarn add @magic-sdk/commons@24.0.5-canary.742.9420309456.0 yarn add @magic-sdk/pnp@22.0.7-canary.742.9420309456.0 yarn add @magic-sdk/provider@28.0.5-canary.742.9420309456.0 yarn add @magic-sdk/react-native-bare@29.0.5-canary.742.9420309456.0 yarn add @magic-sdk/react-native-expo@29.0.5-canary.742.9420309456.0 yarn add @magic-sdk/types@24.0.4-canary.742.9420309456.0 yarn add magic-sdk@28.0.6-canary.742.9420309456.0