Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MagicSigner to inject into polkadot api instance #658

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

octave08
Copy link
Collaborator

@octave08 octave08 commented Nov 2, 2023

📦 Pull Request

[Provide a general summary of the pull request here.]

  • adding MagicSigner to inject into polkadot API instance so that a developer can integrate with Magic like the below easily
const magicSigner = new MagicSigner(magic)
const api = new ApiPromise(wsProvider, { signer: magicSigner });

api.tx.balances
  .transfer('5C5555yEXUcmEJ5kkcCMvdZjUo7NGJiQJMS7vZXEeoMhj3VQ', 123456)
  .signAndSend(SENDER, (status) => { ... });

✅ Fixed Issues

  • [List any fixed issues here like: Fixes #XXXX]

🚨 Test instructions

[Describe any additional context required to test the PR/feature/bug fix.]

⚠️ Don't forget to add a semver label!

Please only add one label:

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @magic-ext/polkadot@16.3.0-canary.658.6732407355.0
# or 
yarn add @magic-ext/polkadot@16.3.0-canary.658.6732407355.0

@octave08 octave08 added the minor Increment the minor version when merged label Nov 2, 2023
@octave08 octave08 requested a review from karljin November 2, 2023 09:58
@octave08 octave08 self-assigned this Nov 2, 2023
Copy link

This pull request has been linked to Shortcut Story #89834: [Polkadot] Add MagicSigner for Polkadot.

@octave08 octave08 force-pushed the jayhwang-sc-89834-polkadot-add-magicsigner-for-polkadot branch from b2cddaf to 99c68a2 Compare November 2, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant