Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add logs for "msgType is not defined" error #544

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

mattupham
Copy link
Contributor

@mattupham mattupham commented Jun 16, 2023

πŸ“¦ Pull Request

  • error seems to be from msgType not being defined, only happening in Next app

βœ… Fixed Issues

https://app.shortcut.com/magic-labs/story/78606/magic-connect-error-n-is-not-defined

🚨 Test instructions

  • install canary SDK in customer repo
Screenshot 2023-06-16 at 11 21 40 AM Screenshot 2023-06-16 at 11 20 54 AM
πŸ“¦ Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @magic-ext/algorand@13.2.1-canary.544.5405340371.0
npm install @magic-ext/aptos@1.2.1-canary.544.5405340371.0
npm install @magic-ext/auth@1.2.1-canary.544.5405340371.0
npm install @magic-ext/avalanche@13.2.1-canary.544.5405340371.0
npm install @magic-ext/bitcoin@13.2.1-canary.544.5405340371.0
npm install @magic-ext/conflux@11.2.1-canary.544.5405340371.0
npm install @magic-ext/cosmos@13.2.1-canary.544.5405340371.0
npm install @magic-ext/ed25519@9.2.1-canary.544.5405340371.0
npm install @magic-ext/flow@13.2.1-canary.544.5405340371.0
npm install @magic-ext/gdkms@1.2.1-canary.544.5405340371.0
npm install @magic-ext/harmony@13.2.1-canary.544.5405340371.0
npm install @magic-ext/icon@13.2.1-canary.544.5405340371.0
npm install @magic-ext/near@13.2.1-canary.544.5405340371.0
npm install @magic-ext/oauth@12.2.1-canary.544.5405340371.0
npm install @magic-ext/oidc@1.1.1-canary.544.5405340371.0
npm install @magic-ext/polkadot@13.2.1-canary.544.5405340371.0
npm install @magic-ext/react-native-bare-oauth@13.2.1-canary.544.5405340371.0
npm install @magic-ext/react-native-expo-oauth@13.2.1-canary.544.5405340371.0
npm install @magic-ext/solana@14.2.1-canary.544.5405340371.0
npm install @magic-ext/taquito@10.2.1-canary.544.5405340371.0
npm install @magic-ext/terra@10.2.1-canary.544.5405340371.0
npm install @magic-ext/tezos@13.2.1-canary.544.5405340371.0
npm install @magic-ext/webauthn@12.2.1-canary.544.5405340371.0
npm install @magic-ext/zilliqa@13.2.1-canary.544.5405340371.0
npm install @magic-sdk/commons@14.2.1-canary.544.5405340371.0
npm install @magic-sdk/pnp@12.2.1-canary.544.5405340371.0
npm install @magic-sdk/provider@18.2.1-canary.544.5405340371.0
npm install @magic-sdk/react-native-bare@19.2.1-canary.544.5405340371.0
npm install @magic-sdk/react-native-expo@19.2.1-canary.544.5405340371.0
npm install magic-sdk@18.2.1-canary.544.5405340371.0
# or 
yarn add @magic-ext/algorand@13.2.1-canary.544.5405340371.0
yarn add @magic-ext/aptos@1.2.1-canary.544.5405340371.0
yarn add @magic-ext/auth@1.2.1-canary.544.5405340371.0
yarn add @magic-ext/avalanche@13.2.1-canary.544.5405340371.0
yarn add @magic-ext/bitcoin@13.2.1-canary.544.5405340371.0
yarn add @magic-ext/conflux@11.2.1-canary.544.5405340371.0
yarn add @magic-ext/cosmos@13.2.1-canary.544.5405340371.0
yarn add @magic-ext/ed25519@9.2.1-canary.544.5405340371.0
yarn add @magic-ext/flow@13.2.1-canary.544.5405340371.0
yarn add @magic-ext/gdkms@1.2.1-canary.544.5405340371.0
yarn add @magic-ext/harmony@13.2.1-canary.544.5405340371.0
yarn add @magic-ext/icon@13.2.1-canary.544.5405340371.0
yarn add @magic-ext/near@13.2.1-canary.544.5405340371.0
yarn add @magic-ext/oauth@12.2.1-canary.544.5405340371.0
yarn add @magic-ext/oidc@1.1.1-canary.544.5405340371.0
yarn add @magic-ext/polkadot@13.2.1-canary.544.5405340371.0
yarn add @magic-ext/react-native-bare-oauth@13.2.1-canary.544.5405340371.0
yarn add @magic-ext/react-native-expo-oauth@13.2.1-canary.544.5405340371.0
yarn add @magic-ext/solana@14.2.1-canary.544.5405340371.0
yarn add @magic-ext/taquito@10.2.1-canary.544.5405340371.0
yarn add @magic-ext/terra@10.2.1-canary.544.5405340371.0
yarn add @magic-ext/tezos@13.2.1-canary.544.5405340371.0
yarn add @magic-ext/webauthn@12.2.1-canary.544.5405340371.0
yarn add @magic-ext/zilliqa@13.2.1-canary.544.5405340371.0
yarn add @magic-sdk/commons@14.2.1-canary.544.5405340371.0
yarn add @magic-sdk/pnp@12.2.1-canary.544.5405340371.0
yarn add @magic-sdk/provider@18.2.1-canary.544.5405340371.0
yarn add @magic-sdk/react-native-bare@19.2.1-canary.544.5405340371.0
yarn add @magic-sdk/react-native-expo@19.2.1-canary.544.5405340371.0
yarn add magic-sdk@18.2.1-canary.544.5405340371.0

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #78606: Magic Connect - Error - n is not defined.

@mattupham mattupham requested a review from bcleary06 June 16, 2023 20:07
@mattupham mattupham added minor Increment the minor version when merged patch Increment the patch version when merged and removed patch Increment the patch version when merged minor Increment the minor version when merged labels Jun 16, 2023
@mattupham mattupham temporarily deployed to production June 16, 2023 20:32 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants