Reject the isLoggedIn Promise if the user has no internet #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o the internet (Blocker for Rarible)
Dizigen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Pull Request
Rarible integration issue:
Rarible requested that isLoggedIn to throw an error if the user is not connected to the internet
They cited this issue as a blocker for release and will not accept doing a navigator.onLine check their side.
The only known way of reproducing the issue is to turn the internet off on their browsers
✅ Fixed Issues
🚨 Test instructions
Integrate the SDK.
Implement
isLoggedInbut do not call it on site load (bind it to an action).Navigate to the site
Turn the internet off
Execute the isLoggedIn call
Please only add one label:
patch: Bug Fix?minor: New Feature?major: Breaking Change?skip-release: It's unnecessary to publish this change.📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @magic-ext/algorand@11.1.1-canary.494.4669951406.0 npm install @magic-ext/avalanche@11.1.1-canary.494.4669951406.0 npm install @magic-ext/bitcoin@11.1.1-canary.494.4669951406.0 npm install @magic-ext/conflux@9.1.1-canary.494.4669951406.0 npm install @magic-ext/cosmos@11.1.1-canary.494.4669951406.0 npm install @magic-ext/ed25519@7.1.1-canary.494.4669951406.0 npm install @magic-ext/flow@11.1.1-canary.494.4669951406.0 npm install @magic-ext/harmony@11.1.1-canary.494.4669951406.0 npm install @magic-ext/icon@11.1.1-canary.494.4669951406.0 npm install @magic-ext/near@11.1.1-canary.494.4669951406.0 npm install @magic-ext/oauth@10.1.1-canary.494.4669951406.0 npm install @magic-ext/polkadot@11.1.1-canary.494.4669951406.0 npm install @magic-ext/react-native-bare-oauth@11.2.1-canary.494.4669951406.0 npm install @magic-ext/react-native-expo-oauth@11.2.1-canary.494.4669951406.0 npm install @magic-ext/solana@12.1.1-canary.494.4669951406.0 npm install @magic-ext/taquito@8.1.1-canary.494.4669951406.0 npm install @magic-ext/terra@8.1.1-canary.494.4669951406.0 npm install @magic-ext/tezos@11.1.1-canary.494.4669951406.0 npm install @magic-ext/webauthn@10.1.1-canary.494.4669951406.0 npm install @magic-ext/zilliqa@11.1.1-canary.494.4669951406.0 npm install @magic-sdk/commons@12.1.1-canary.494.4669951406.0 npm install @magic-sdk/pnp@10.1.1-canary.494.4669951406.0 npm install @magic-sdk/provider@16.1.1-canary.494.4669951406.0 npm install @magic-sdk/react-native-bare@17.2.1-canary.494.4669951406.0 npm install @magic-sdk/react-native-expo@17.2.1-canary.494.4669951406.0 npm install magic-sdk@16.1.1-canary.494.4669951406.0 # or yarn add @magic-ext/algorand@11.1.1-canary.494.4669951406.0 yarn add @magic-ext/avalanche@11.1.1-canary.494.4669951406.0 yarn add @magic-ext/bitcoin@11.1.1-canary.494.4669951406.0 yarn add @magic-ext/conflux@9.1.1-canary.494.4669951406.0 yarn add @magic-ext/cosmos@11.1.1-canary.494.4669951406.0 yarn add @magic-ext/ed25519@7.1.1-canary.494.4669951406.0 yarn add @magic-ext/flow@11.1.1-canary.494.4669951406.0 yarn add @magic-ext/harmony@11.1.1-canary.494.4669951406.0 yarn add @magic-ext/icon@11.1.1-canary.494.4669951406.0 yarn add @magic-ext/near@11.1.1-canary.494.4669951406.0 yarn add @magic-ext/oauth@10.1.1-canary.494.4669951406.0 yarn add @magic-ext/polkadot@11.1.1-canary.494.4669951406.0 yarn add @magic-ext/react-native-bare-oauth@11.2.1-canary.494.4669951406.0 yarn add @magic-ext/react-native-expo-oauth@11.2.1-canary.494.4669951406.0 yarn add @magic-ext/solana@12.1.1-canary.494.4669951406.0 yarn add @magic-ext/taquito@8.1.1-canary.494.4669951406.0 yarn add @magic-ext/terra@8.1.1-canary.494.4669951406.0 yarn add @magic-ext/tezos@11.1.1-canary.494.4669951406.0 yarn add @magic-ext/webauthn@10.1.1-canary.494.4669951406.0 yarn add @magic-ext/zilliqa@11.1.1-canary.494.4669951406.0 yarn add @magic-sdk/commons@12.1.1-canary.494.4669951406.0 yarn add @magic-sdk/pnp@10.1.1-canary.494.4669951406.0 yarn add @magic-sdk/provider@16.1.1-canary.494.4669951406.0 yarn add @magic-sdk/react-native-bare@17.2.1-canary.494.4669951406.0 yarn add @magic-sdk/react-native-expo@17.2.1-canary.494.4669951406.0 yarn add magic-sdk@16.1.1-canary.494.4669951406.0