Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance expect exception tests #86

Merged
merged 3 commits into from Oct 29, 2019
Merged

Enhance expect exception tests #86

merged 3 commits into from Oct 29, 2019

Conversation

peter279k
Copy link
Contributor

@peter279k peter279k commented Oct 27, 2019

Description

Changed log

  • To support future PHPUnit 8.x versions about deprecated @expectedException warning message, using the expectException and expectExceptionMessage instead.
  • Removing unused @throws annotation.
  • Upgrading the PHPUnit 7.x version and it requires php-7.1 version at least.

The deprecated warning message is as follows:

 with data set "empty string" ('')
The @expectedException, @expectedExceptionCode, @expectedExceptionMessage, and @expectedExceptionMessageRegExp annotations are deprecated. They will be removed in PHPUnit 9. Refactor your test to use expectException(), expectExceptionCode(), expectExceptionMessage(), or expectExceptionMessageRegExp() instead.

The related issue is available here.

Manual testing scenarios

  • Travis CI build will be passed.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages

@shiftedreality shiftedreality added the community PR/issue origin label Oct 28, 2019
@shiftedreality
Copy link
Member

Hello @peter279k

Thank you for your contribution! I've created internal task https://magento2.atlassian.net/browse/MAGECLOUD-4556 to process and merge your PR

@YPyltiai YPyltiai added the improvement issue type label Oct 28, 2019
@YPyltiai YPyltiai added this to Dev in progress in Backlog via automation Oct 28, 2019
@YPyltiai YPyltiai added the Release: 1.0.0 Magento-Cloud-Docker Release label Oct 28, 2019
@mveeramneni mveeramneni added the Progress: review PR/issue status label Oct 28, 2019
@shiftedreality shiftedreality changed the base branch from develop to 1.0 October 29, 2019 15:05
Backlog automation moved this from Dev in progress to QA in progress Oct 29, 2019
@shiftedreality
Copy link
Member

@peter279k PR overall looks good!

Please merge 1.0 branch and fix a conflict, so I can proceed with merging.

@shiftedreality shiftedreality added Progress: accept PR/issue status and removed Progress: review PR/issue status labels Oct 29, 2019
@peter279k
Copy link
Contributor Author

@peter279k PR overall looks good!

Please merge 1.0 branch and fix a conflict, so I can proceed with merging.

Hi @shiftedreality, thanks for your reply.

Now I've resolved composer.json conflict from the 1.0 branch.

@shiftedreality shiftedreality merged commit 1246e50 into magento:1.0 Oct 29, 2019
Backlog automation moved this from QA in progress to Done Oct 29, 2019
@shiftedreality
Copy link
Member

Thanks a lot for your contribution!

@peter279k peter279k deleted the enhance_exception_tests branch October 29, 2019 17:45
@shiftedreality shiftedreality removed this from Done in Backlog Jan 22, 2020
magento-devops-reposync-svc pushed a commit to magento-dockerhub/magento-cloud-docker that referenced this pull request Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community PR/issue origin improvement issue type Progress: accept PR/issue status Release: 1.0.0 Magento-Cloud-Docker Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants